Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tendermint dependency to v0.30 #125

Merged
merged 1 commit into from
Feb 12, 2019
Merged

update tendermint dependency to v0.30 #125

merged 1 commit into from
Feb 12, 2019

Conversation

liamsi
Copy link
Contributor

@liamsi liamsi commented Feb 12, 2019

update to tendermint v0.30 and bump version to 0.12.1 (for immediate release)

Dependency to tendermint v0.27.0-dev1 was causing some inconvenience when developing an app which has the sdk and iavl as a dependency.

cc @alessio

@liamsi liamsi requested review from ebuchman and melekes February 12, 2019 10:42
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -8,7 +8,7 @@

[[constraint]]
name = "github.com/tendermint/tendermint"
version = "v0.27.0-dev1"
version = "v0.30.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why iavl depends on Tendermint again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it uses some parts of what previously tmlibs: c8114f1#diff-836546cc53507f6b2d581088903b1785
more dependencies introduced due to:
#105 (tendermint/tendermint#1912, tendermint/tendermint#2298)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also ref: #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants