Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ibc references #736

Merged
merged 1 commit into from
Mar 8, 2021
Merged

update ibc references #736

merged 1 commit into from
Mar 8, 2021

Conversation

colin-axner
Copy link
Contributor

Closes: #XXX

Heads up, the readme link will need to change once the ICS spec repository has finished its migration


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@shahankhatch shahankhatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are pre-emptive of the upcoming sdk bump changes in gaia. Thanks @colin-axner!

@shahankhatch shahankhatch merged commit 9f22021 into main Mar 8, 2021
@shahankhatch shahankhatch deleted the colin/ibc branch March 8, 2021 17:23
shahankhatch pushed a commit that referenced this pull request Mar 9, 2021
shahankhatch pushed a commit that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants