Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add tm-version #657

Merged
merged 4 commits into from
Feb 19, 2021
Merged

build: add tm-version #657

merged 4 commits into from
Feb 19, 2021

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Feb 19, 2021

Closes: #XXX

Description

  • Add Tendermint version to ldflags to be displayed in RPC
    Example:
go install -mod=readonly -tags "netgo ledger" -ldflags 
'-X github.com/cosmos/cosmos-sdk/version.Name=gaia 
-X github.com/cosmos/cosmos-sdk/version.AppName=gaiad 
-X github.com/cosmos/cosmos-sdk/version.Version=3.0.0-58-g56fc3d6 
-X github.com/cosmos/cosmos-sdk/version.Commit=56fc3d693b742964b836183664d5b8b15a8ec80a 
-X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger" 
-X github.com/tendermint/tendermint/version.TMCoreSemVer=v0.34.7 -w -s' -trimpath  ./...

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@tac0turtle tac0turtle marked this pull request as ready for review February 19, 2021 12:35
@tac0turtle tac0turtle self-assigned this Feb 19, 2021
@shahankhatch shahankhatch merged commit c1f235f into main Feb 19, 2021
@shahankhatch shahankhatch deleted the marko/add_tm_version branch February 19, 2021 20:11
shahankhatch pushed a commit that referenced this pull request Feb 19, 2021
* add tm-version

* fix sed

* resolve merge from other changes to Makefile
shahankhatch pushed a commit that referenced this pull request Feb 19, 2021
* add tm-version

* fix sed

* resolve merge from other changes to Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants