feat!: Bump ICS to include inactive validators #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade ICS version * Change app wiring * Add migration * Fix linting * Add initialization for LastProviderConsensusValSet * Use CamelCase for const names * Remove unnecessary migration and parameter check * Adjust comment to mention LastProviderConsensusValidatorSet initialization * Remove panics and replace with error returns * Improve logging * Lint
This reverts commit 06f58d3.
p-offtermatt
requested review from
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
insumity
reviewed
Aug 14, 2024
insumity
reviewed
Aug 14, 2024
insumity
reviewed
Aug 14, 2024
| // in Interchain Security, after which the number of validators | ||
| // participating in consensus on the Cosmos Hub will be governed by the | ||
| // MaxProviderConsensusValidators parameter in the provider module. | ||
| func SetMaxValidators(ctx sdk.Context, stakingKeeper stakingkeeper.Keeper) error { |
There was a problem hiding this comment.
Why is this called Set... while the previous one Initialize...?
insumity
approved these changes
Aug 14, 2024
mpoke
reviewed
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #3259 after it was merged by accident.
Upgrades ICS to current main (which includes inactive validators).
Best reviewed by commit.