-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump github.com/cosmos/ibc-go/v8 from 8.3.2 to 8.4.0 (backport #3231) #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Bumps [github.com/cosmos/ibc-go/v8](https://github.com/cosmos/ibc-go) from 8.3.2 to 8.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/cosmos/ibc-go/releases">github.com/cosmos/ibc-go/v8's releases</a>.</em></p> <blockquote> <h2>v8.4.0</h2> <p>We present here a summary of the most relevant changes, please see the <a href="https://github.com/cosmos/ibc-go/blob/v8.4.0/CHANGELOG.md">v8.4.0 changelog</a> for more details. Please note that this release, as indicated in our <a href="https://github.com/cosmos/ibc-go/blob/main/RELEASES.md">release versioning policy</a>, is state machine breaking and requires a coordinated upgrade.</p> <h3>core/04-channel</h3> <ul> <li>An <a href="https://github.com/cosmos/ibc-go/blob/v8.4.0/modules/core/04-channel/keeper/upgrade.go#L459-L464">extra check has been added to the <code>ChannelUpgradeConfirm</code> handler to make sure that the upgrades are compatible</a> and thus prevent that an upgrade completes with channel ends in incompatible state. <strong>We have retracted v8.2.x and v8.3.x</strong> and <strong>all chains planning to use channel upgradability are strongly recommended to upgrade to this version</strong>. Thank you very much to <a href="https://github.com/siburu"><code>@siburu</code></a> and <a href="https://github.com/bluele"><code>@bluele</code></a> for responsibly reporting this bug through our <a href="https://hackerone.com/cosmos?type=team&view_policy=true">bug bounty program</a>.</li> </ul> <h3>apps/transfer</h3> <ul> <li>If the <code>Amount</code> of the <a href="https://github.com/cosmos/ibc-go/blob/v8.4.0/modules/apps/transfer/types/tx.pb.go#L44"><code>Token</code> field in <code>MsgTransfer</code></a> is set to the maximum value for a 256-bit unsigned integer (i.e. 2^256 - 1), then the whole balance of the corresponding denomination will be transferred. The helper function <a href="https://github.com/cosmos/ibc-go/blob/v8.4.0/modules/apps/transfer/types/coin.go#L60"><code>UnboundedSpendLimit</code> in the <code>types</code> package of the <code>transfer</code> module</a> provides the sentinel value that can be used.</li> </ul> <hr /> <p>To learn more about ibc-go versioning, please read our <a href="https://github.com/cosmos/ibc-go/blob/main/RELEASES.md">RELEASES.md</a>.</p> <p><strong>IMPORTANT</strong>: Please read the migration guides for any versions of ibc-go that you might be going through when upgrading to this version. For example: if you upgrade from the IBC module contained in the Cosmos SDK 0.42.0 to SDK v0.50.7 and ibc-go v8.4.0, please follow:</p> <ol> <li>The <a href="https://github.com/cosmos/ibc-go/blob/main/docs/migrations/sdk-to-v1.md">migration from SDK 0.41.x or 0.42.x to the IBC module in the ibc-go repository based on the SDK v0.44.x</a>.</li> <li>The <a href="https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/03-v1-to-v2.md">migration from ibc-go v1 to v2</a>.</li> <li>The <a href="https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/04-v2-to-v3.md">migration from ibc-go v2 to v3</a>.</li> <li>The <a href="https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/05-v3-to-v4.md">migration from ibc-go v3 to v4</a>.</li> <li>The <a href="https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/06-v4-to-v5.md">migration from ibc-go v4 to v5</a>.</li> <li>The <a href="https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/07-v5-to-v6.md">migration from ibc-go v5 to v6</a>.</li> <li>The <a href="https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/08-v6-to-v7.md">migration from ibc-go v6 to v7</a>.</li> <li>The <a href="https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/09-v7-to-v7_1.md">migration from ibc-go v7 to v7.1</a>.</li> <li>The <a href="https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/10-v7_2-to-v7_3.md">migration from ibc-go v7.2 to v7.3</a>.</li> <li>The <a href="https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/11-v7-to-v8.md">migration from ibc-go v7 to v8</a>.</li> <li>The <a href="https://github.com/cosmos/ibc-go/blob/main/docs/docs/05-migrations/12-v8-to-v8_1.md">migration from ibc-go v8 to v8.1</a>.</li> </ol> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/cosmos/ibc-go/blob/v8.4.0/CHANGELOG.md">github.com/cosmos/ibc-go/v8's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/cosmos/ibc-go/releases/tag/v8.4.0">v8.4.0</a> - 2024-07-29</h2> <h3>Improvements</h3> <ul> <li>(core/04-channel) <a href="https://redirect.github.com/cosmos/ibc-go/pull/6871">#6871</a> Add channel ordering to write acknowledgement event.</li> </ul> <h3>Features</h3> <ul> <li>(apps/transfer) <a href="https://redirect.github.com/cosmos/ibc-go/pull/6877">#6877</a> Added the possibility to transfer the entire user balance of a particular denomination by using <a href="https://github.com/cosmos/ibc-go/blob/cdaaa94546af79760317f22bc93f270e3d754c84/modules/apps/transfer/types/coin.go#L60-L62"><code>UnboundedSpendLimit</code></a> as the token amount.</li> </ul> <h3>Bug Fixes</h3> <ul> <li>(core/04-channel) <a href="https://redirect.github.com/cosmos/ibc-go/pull/6935">#6935</a> Check upgrade compatibility in <code>ChanUpgradeConfirm</code>.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/cosmos/ibc-go/commit/8479edf4d0d3f93ad5138952ae74859d7ba33f74"><code>8479edf</code></a> retract v8.2.x and v8.3.x (<a href="https://redirect.github.com/cosmos/ibc-go/issues/6965">#6965</a>)</li> <li><a href="https://github.com/cosmos/ibc-go/commit/8b6edc24bc77e07c06ce14b1dd76df828e14487f"><code>8b6edc2</code></a> update changelog before v8.4.0 release</li> <li><a href="https://github.com/cosmos/ibc-go/commit/cdaaa94546af79760317f22bc93f270e3d754c84"><code>cdaaa94</code></a> fix(state!): check upgrade compatibility in channel upgrade confirm (backport...</li> <li><a href="https://github.com/cosmos/ibc-go/commit/babe971a2cca236addf240ddb5f9887ca75fb333"><code>babe971</code></a> (feat) Add possibility to transfer entire balance. (backport <a href="https://redirect.github.com/cosmos/ibc-go/issues/6877">#6877</a>) (<a href="https://redirect.github.com/cosmos/ibc-go/issues/6930">#6930</a>)</li> <li><a href="https://github.com/cosmos/ibc-go/commit/d8789abbba57fc9d17e7993994a9c6af5ad37a7c"><code>d8789ab</code></a> events: add channel ordering to write acknowledgement event (<a href="https://redirect.github.com/cosmos/ibc-go/issues/6867">#6867</a>) (<a href="https://redirect.github.com/cosmos/ibc-go/issues/6871">#6871</a>)</li> <li><a href="https://github.com/cosmos/ibc-go/commit/db3942eae5fcdc00cefc870e7134c8f0a88c82cf"><code>db3942e</code></a> Update CHANGELOG.md</li> <li>See full diff in <a href="https://github.com/cosmos/ibc-go/compare/v8.3.2...v8.4.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/cosmos/ibc-go/v8&package-manager=go_modules&previous-version=8.3.2&new-version=8.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> (cherry picked from commit e714d06)
mergify
bot
requested review from
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
July 29, 2024 11:13
MSalopek
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/cosmos/ibc-go/v8 from 8.3.2 to 8.4.0.
Release notes
Sourced from github.com/cosmos/ibc-go/v8's releases.
Changelog
Sourced from github.com/cosmos/ibc-go/v8's changelog.
Commits
8479edf
retract v8.2.x and v8.3.x (#6965)8b6edc2
update changelog before v8.4.0 releasecdaaa94
fix(state!): check upgrade compatibility in channel upgrade confirm (backport...babe971
(feat) Add possibility to transfer entire balance. (backport #6877) (#6930)d8789ab
events: add channel ordering to write acknowledgement event (#6867) (#6871)db3942e
Update CHANGELOG.mdDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)This is an automatic backport of pull request #3231 done by [Mergify](https://mergify.com).