Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: wire ibcfee module #3038

Merged
merged 13 commits into from
Apr 15, 2024
Merged

feat!: wire ibcfee module #3038

merged 13 commits into from
Apr 15, 2024

Conversation

MSalopek
Copy link
Contributor

@MSalopek MSalopek commented Apr 2, 2024

Description

Closes: #2948

This PR adds support for IBC fee middleware.

The middleware is connected to the transfer and ICA modules.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

tests/e2e/e2e_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments below.

app/keepers/keepers.go Outdated Show resolved Hide resolved
app/keepers/keepers.go Show resolved Hide resolved
app/keepers/keepers.go Show resolved Hide resolved
app/keepers/keepers.go Show resolved Hide resolved
app/keepers/keepers.go Show resolved Hide resolved
@@ -114,6 +117,7 @@ type AppKeepers struct {

// Modules
ICAModule ica.AppModule
IBCFeeKeeper ibcfeekeeper.Keeper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need also a scoped keeper for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@bermuell bermuell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spelling

app/keepers/keepers.go Outdated Show resolved Hide resolved
@MSalopek MSalopek merged commit 6c6a514 into main Apr 15, 2024
17 checks passed
@MSalopek MSalopek deleted the masa/add-ibcfee branch April 15, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable IBC fee middleware
5 participants