-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support for metaprotocol types #2960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainoe
reviewed
Feb 22, 2024
Co-authored-by: Simon Noetzlin <[email protected]>
MSalopek
requested review from
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
February 23, 2024 15:46
sainoe
reviewed
Feb 26, 2024
sainoe
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work!
Co-authored-by: Philip Offtermatt <[email protected]>
Co-authored-by: Simon Noetzlin <[email protected]>
mpoke
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @MSalopek. Add changelog entry.
mergify bot
pushed a commit
that referenced
this pull request
Feb 27, 2024
* experimental: add message types for metaprotocols * experimental: refine multiprotocols support * Update x/metaprotocols/types/keys.go Co-authored-by: Simon Noetzlin <[email protected]> * appease linter * add docs and rebuild protos * add docs, tests, readme * update docs * update e2e - enable all * appease linter * Update tests/e2e/e2e_bank_test.go Co-authored-by: Philip Offtermatt <[email protected]> * Update x/metaprotocols/README.md Co-authored-by: Simon Noetzlin <[email protected]> * docs: update changelog files --------- Co-authored-by: Simon Noetzlin <[email protected]> Co-authored-by: Philip Offtermatt <[email protected]> (cherry picked from commit 3ae75ed) # Conflicts: # .changelog/v15.0.0/dependencies/2960-add-metaprotocols-support.md
MSalopek
added a commit
that referenced
this pull request
Feb 27, 2024
* feat!: support for metaprotocol types (#2960) * experimental: add message types for metaprotocols * experimental: refine multiprotocols support * Update x/metaprotocols/types/keys.go Co-authored-by: Simon Noetzlin <[email protected]> * appease linter * add docs and rebuild protos * add docs, tests, readme * update docs * update e2e - enable all * appease linter * Update tests/e2e/e2e_bank_test.go Co-authored-by: Philip Offtermatt <[email protected]> * Update x/metaprotocols/README.md Co-authored-by: Simon Noetzlin <[email protected]> * docs: update changelog files --------- Co-authored-by: Simon Noetzlin <[email protected]> Co-authored-by: Philip Offtermatt <[email protected]> (cherry picked from commit 3ae75ed) # Conflicts: # .changelog/v15.0.0/dependencies/2960-add-metaprotocols-support.md * chore: manually add files in the correct places * chore: manually mv file to correct place --------- Co-authored-by: MSalopek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
x/metaprotocol
module adds support for encoding and decoding additional fields attached to transactions.extension_options
andnon_critical_extension_options
are optional fields that can be used to attach data to valid transactions. The fields are validated by the blockchain, but they are not used in any way. The fields pass validation if they are provided as empty lists ([ ]
) or they use a list ofExtensionData
types.The application does not use the attached data but it does ensure that the correct type is provided and that it can be successfully unmarshalled. The attached data will be part of a block.
Here is an example of a correctly formed
non_critical_extension_options
field:Here is an example of a correctly populated
non_critical_extension_options
on abank.MsgSend
transaction: