Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update mergify and dependabot #2750

Merged
merged 1 commit into from
Sep 25, 2023
Merged

chore: update mergify and dependabot #2750

merged 1 commit into from
Sep 25, 2023

Conversation

mpoke
Copy link
Contributor

@mpoke mpoke commented Sep 22, 2023

Description

Closes: NA


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

Copy link
Contributor

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment. I think it probably shouldn't be addressed in this PR anyways, but I'll let you decide how to proceed/if you think it's worth doing

@@ -41,7 +41,7 @@ updates:
directory: "/"
schedule:
interval: daily
target-branch: "release/v10.0.x"
target-branch: "release/v11.x"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment that this is the last 3 releases, with a reference to e.g. https://github.com/cosmos/gaia/blob/main/RELEASING.md#major-release-maintenance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep it as at the moment the latest two in-production releases are v11 and v12.

@@ -24,29 +24,29 @@ pull_request_rules:
{{ title }} (#{{ number }})
{{ body }}

- name: Backport patches to the release/v10.0.x branch
- name: Backport patches to the release/v11.x branch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, maybe we should put a comment that this is supposed to be the last 3 releases included here

@mpoke mpoke merged commit eb2f5e1 into main Sep 25, 2023
@mpoke mpoke deleted the marius/v14-bots-update branch September 25, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants