add spam prevention antehandler #2262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
sainoe and
shaspitz
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2262 +/- ##
==========================================
- Coverage 84.76% 83.83% -0.93%
==========================================
Files 21 22 +1
Lines 1483 1540 +57
==========================================
+ Hits 1257 1291 +34
- Misses 181 201 +20
- Partials 45 48 +3
|
|
Done, tests are up to date. |
mpoke
approved these changes
Mar 9, 2023
mergify bot
pushed a commit
that referenced
this pull request
Mar 9, 2023
* add spam prevention antehandler * sort imports * run make format * fix misleading var names * update wrong test cases * fix failing gov tests * fix linter errors * uncomment e2e gov steps logs (cherry picked from commit 23d9f67)
shaspitz
pushed a commit
that referenced
this pull request
Mar 9, 2023
* add spam prevention antehandler * sort imports * run make format * fix misleading var names * update wrong test cases * fix failing gov tests * fix linter errors * uncomment e2e gov steps logs (cherry picked from commit 23d9f67) Co-authored-by: MSalopek <[email protected]>
tbruyelle
reviewed
Mar 9, 2023
Comment on lines
+60
to
+64
| for _, v := range execMsg.Msgs { | ||
| var innerMsg sdk.Msg | ||
| if err := g.cdc.UnpackAny(v, &innerMsg); err != nil { | ||
| return sdkerrors.Wrapf(sdkerrors.ErrUnauthorized, "cannot unmarshal authz exec msgs") | ||
| } |
There was a problem hiding this comment.
@MSalopek Sorry to ask after the merge, but couldn't this code be simplified by calling MsgExec.GetMessages() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds governance spam prevention antehandler and minimal testing.
Earlier, a github member opened a PR which they closed after receiving feedback:
The changes were modelled after:
Closes: #2246