Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrating ica to rho #1530

Merged
merged 39 commits into from
Sep 16, 2022
Merged

feat: integrating ica to rho #1530

merged 39 commits into from
Sep 16, 2022

Conversation

yaruwangway
Copy link
Contributor

@yaruwangway yaruwangway commented Jun 9, 2022 •
edited
Loading

This PR is for rho:

  • add ica controller
  • add ica auth (mauth module as a gaia module)
  • add cli to makefile to generate proto (optional)
  • complete the todos

@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #1530 (e8f99ac) into main (20c340c) will increase coverage by 0.89%.
The diff coverage is 68.37%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
+ Coverage   51.43%   52.33%   +0.89%     
==========================================
  Files          13       16       +3     
  Lines        1670     1779     +109     
==========================================
+ Hits          859      931      +72     
- Misses        787      821      +34     
- Partials       24       27       +3

@yaruwangway yaruwangway changed the title integrating ica to rho feat: integrating ica to rho Jul 29, 2022
@Anmol1696 Anmol1696 mentioned this pull request Aug 1, 2022
Merged
@yaruwangway yaruwangway marked this pull request as ready for review August 10, 2022 14:23
@mmulji-ic mmulji-ic added the rho label Aug 15, 2022
yaruwangway
yaruwangway commented Aug 18, 2022
View reviewed changes
x/icamauth/keeper/keeper_test.go
)

var (
// TODO: Cosmos-SDK ADR-28: Update crypto.AddressHash() when sdk uses address.Module()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends on sdk issue cosmos/cosmos-sdk#10225

@yaruwangway
Copy link
Contributor Author

yaruwangway commented Aug 30, 2022 •
edited
Loading

updates:

@yaruwangway yaruwangway requested a review from Pantani as a code owner September 6, 2022 16:04
@yaruwangway yaruwangway changed the title feat: integrating ica to rho (WIP) feat: integrating ica to rho Sep 7, 2022
glnro
glnro reviewed Sep 14, 2022
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
x/icamauth/README.md Outdated Show resolved Hide resolved
okwme
okwme reviewed Sep 15, 2022
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
okwme
okwme approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@okwme okwme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yaruwangway yaruwangway merged commit d69d7f1 into main Sep 16, 2022
@yaruwangway yaruwangway deleted the yaru/ica branch September 16, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glnro glnro glnro left review comments

@okwme okwme okwme approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@zmanian zmanian Awaiting requested review from zmanian zmanian is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@cmwaters cmwaters Awaiting requested review from cmwaters

@jackzampolin jackzampolin Awaiting requested review from jackzampolin jackzampolin is a code owner

@mmulji-ic mmulji-ic Awaiting requested review from mmulji-ic

@Pantani Pantani Awaiting requested review from Pantani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaruwangway @okwme @glnro @mmulji-ic