Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go to 1.13 & Latest SDK Master #119

Merged
merged 41 commits into from
Sep 10, 2019
Merged

Upgrade go to 1.13 & Latest SDK Master #119

merged 41 commits into from
Sep 10, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Sep 4, 2019 •
edited
Loading

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Sep 5, 2019 •
edited
Loading

Mind helping out here @fedekunze with simulation updates?

@alexanderbez alexanderbez marked this pull request as ready for review September 9, 2019 18:25
@alexanderbez alexanderbez added R4R and removed WIP labels Sep 9, 2019
AdityaSripal
AdityaSripal reviewed Sep 9, 2019
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
@fedekunze fedekunze mentioned this pull request Sep 9, 2019
Closed
4 tasks
@mircea-c mircea-c force-pushed the bez/go-1.13-upgrade branch 2 times, most recently from 68f2def to 7ceed8c Compare September 10, 2019 12:31
alexanderbez and others added 22 commits September 10, 2019 08:32
@alexanderbez
Copy link
Contributor Author

Blocked on cosmos/cosmos-sdk#5024

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d624ca1). Click here to learn what that means.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage          ?   66.32%           
=========================================
  Files             ?        4           
  Lines             ?      490           
  Branches          ?        0           
=========================================
  Hits              ?      325           
  Misses            ?      134           
  Partials          ?       31

@alexanderbez alexanderbez merged commit 6fa5988 into master Sep 10, 2019
@alexanderbez alexanderbez deleted the bez/go-1.13-upgrade branch September 10, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSripal AdityaSripal AdityaSripal left review comments

@fedekunze fedekunze fedekunze approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@colin-axner colin-axner Awaiting requested review from colin-axner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexanderbez @codecov-io @AdityaSripal @fedekunze