Fix rocksdb build tag usage #1135

faddat · 2021-12-28T01:52:20Z

this replaces the obsolete tecbot/gorocksdb library with the cosnmosified version.

Alternative to this is an update + release to tm-db. Maybe just a release.

zmanian · 2021-12-28T01:54:52Z

I don't understand the purpose of this PR?

zmanian · 2021-12-28T01:55:23Z

It looks like adding an unused dependency to go.mod

codecov · 2021-12-28T01:55:55Z

Codecov Report

Merging #1135 (1827e40) into main (1bcbf62) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   12.78%   12.78%           
=======================================
  Files           9        9           
  Lines        1259     1259           
=======================================
  Hits          161      161           
  Misses       1092     1092           
  Partials        6        6

faddat · 2021-12-28T01:59:15Z

it is true! It looks that way. However, without that....

go install -tags rocksdb ./...

does not work because tecbot/rocksdb is quite out of date and imported by tm-db v0.6.6.

Also, I am making several of these currently and firing them off undocumented like:

gh pr create

faddat · 2021-12-28T02:04:09Z

https://github.com/tendermint/tm-db/blob/06fdc12b3cc0ff8eb87ec0cd0b5daa9cb5091d2b/go.mod#L41

... is better, I'll amend

faddat · 2021-12-28T02:06:38Z

Probably would also help if I were to say:

Works towards: #1134

tac0turtle

utACK, did test this? I know cosmos is on a newer version of rocks.

faddat · 2022-01-02T02:12:34Z

I've tested it. I think all it sidesteps is the outdated version in the newest release of tm-db.

So could be solved with a new release of tm-db or also using the latest commit hash of tm-db.

Adding one more bit now, just using v1.1.1 of gorocksdb from cosmos. mildly cleaner.

okwme · 2022-01-12T13:37:22Z

Feels dangerous to be overwriting upstream dependencies. As you mentioned the correct way would be for tm-db to update and to incorporate those updates. Is there any reason why this can't wait for then?

tac0turtle · 2022-01-12T13:51:25Z

tm-db has merged the work just not cut a release. Not sure when that will happen, that repo is deprecated more or less

faddat · 2022-01-16T17:04:53Z

Marko, tm-db is deprecated?

Can you tell me more?

Thanks!

@okwme -- this has been used on several chains successfully. It dramatically improves sync speed and query rate. For gaia, we can hit the trifecta-- state sync with rocksdb. And then it utterly flies.

For me, my specific use case for this has been ibc relaying. The difference is pretty extreme.

gitpod has been adding these.... don't want it of course.

zmanian · 2022-01-19T09:26:28Z

I'm feeling more in favor of merging this based on other usage of rocksdb I see in the ecosystem.

* main: Update cosmos-hub-roadmap-2.0.md (cosmos#1224) Fix rocksdb build tag usage (cosmos#1135) versions (cosmos#1100) Update cosmos-hub-roadmap-2.0.md Liquidity (cosmos#1220) Updates to Validator Docs (cosmos#1207) Update joining mainnet documentation (cosmos#1146) Update Ledger doc with Keplr (cosmos#1205) # Conflicts: # go.sum

* this paves the way for widespread rocksdb usage * rocksdb * Use latest cosmos/gorocksdb * Delete .gitpod.yml gitpod has been adding these.... don't want it of course. * go mod tidy Co-authored-by: billy rennekamp <[email protected]>

* app.toml template gRPCWeb port conflict fix (#1230) Co-authored-by: billy rennekamp <[email protected]> * Update statesync.bash (#1208) * Update statesync.bash This config should only use seeds, and shouldn't have a persistent peer * Update statesync.bash having several rpcs is better than depending on one Co-authored-by: billy rennekamp <[email protected]> * build: bump liquidity to v1.4.4 from v1.4.2 (#1210) * build: bump liquidity to v1.4.4-rc1 from v1.4.2 * build: bump liquidity to v1.4.4 * Bump github.com/cosmos/ibc-go/v2 from 2.0.2 to 2.0.3 (#1231) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.3/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: billy rennekamp <[email protected]> * Fix rocksdb build tag usage (#1135) * this paves the way for widespread rocksdb usage * rocksdb * Use latest cosmos/gorocksdb * Delete .gitpod.yml gitpod has been adding these.... don't want it of course. * go mod tidy Co-authored-by: billy rennekamp <[email protected]> * 1159 update state sync configs (#1160) * Update default snapshot configs * Refactor * Fix override to include default template Co-authored-by: billy rennekamp <[email protected]> * Bump github.com/tendermint/tm-db from 0.6.4 to 0.6.6 (#1116) Bumps [github.com/tendermint/tm-db](https://github.com/tendermint/tm-db) from 0.6.4 to 0.6.6. - [Release notes](https://github.com/tendermint/tm-db/releases) - [Changelog](https://github.com/tendermint/tm-db/blob/master/CHANGELOG.md) - [Commits](tendermint/tm-db@v0.6.4...v0.6.6) --- updated-dependencies: - dependency-name: github.com/tendermint/tm-db dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marko <[email protected]> * tm-db version 0.6.4 * chore: update changelog Co-authored-by: Mariya <[email protected]> Co-authored-by: billy rennekamp <[email protected]> Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: dongsam <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: lg <[email protected]> Co-authored-by: Marko <[email protected]>

* Release/v6.0.1 (#1255) * app.toml template gRPCWeb port conflict fix (#1230) Co-authored-by: billy rennekamp <[email protected]> * Update statesync.bash (#1208) * Update statesync.bash This config should only use seeds, and shouldn't have a persistent peer * Update statesync.bash having several rpcs is better than depending on one Co-authored-by: billy rennekamp <[email protected]> * build: bump liquidity to v1.4.4 from v1.4.2 (#1210) * build: bump liquidity to v1.4.4-rc1 from v1.4.2 * build: bump liquidity to v1.4.4 * Bump github.com/cosmos/ibc-go/v2 from 2.0.2 to 2.0.3 (#1231) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.3/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: billy rennekamp <[email protected]> * Fix rocksdb build tag usage (#1135) * this paves the way for widespread rocksdb usage * rocksdb * Use latest cosmos/gorocksdb * Delete .gitpod.yml gitpod has been adding these.... don't want it of course. * go mod tidy Co-authored-by: billy rennekamp <[email protected]> * 1159 update state sync configs (#1160) * Update default snapshot configs * Refactor * Fix override to include default template Co-authored-by: billy rennekamp <[email protected]> * Bump github.com/tendermint/tm-db from 0.6.4 to 0.6.6 (#1116) Bumps [github.com/tendermint/tm-db](https://github.com/tendermint/tm-db) from 0.6.4 to 0.6.6. - [Release notes](https://github.com/tendermint/tm-db/releases) - [Changelog](https://github.com/tendermint/tm-db/blob/master/CHANGELOG.md) - [Commits](tendermint/tm-db@v0.6.4...v0.6.6) --- updated-dependencies: - dependency-name: github.com/tendermint/tm-db dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marko <[email protected]> * tm-db version 0.6.4 * chore: update changelog Co-authored-by: Mariya <[email protected]> Co-authored-by: billy rennekamp <[email protected]> Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: dongsam <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: lg <[email protected]> Co-authored-by: Marko <[email protected]> * cherrypicked v0.44.6 PR * updated changelog and minor changes * chore: update CHANGELOG * chore: update go.mod to be in sync with simapp v0.44.6 * Update CHANGELOG.md Co-authored-by: yaruwangway <[email protected]> Co-authored-by: yaruwangway <[email protected]> Co-authored-by: Mariya <[email protected]> Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: dongsam <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: lg <[email protected]> Co-authored-by: Marko <[email protected]>

* app.toml template gRPCWeb port conflict fix (#1230) Co-authored-by: billy rennekamp <[email protected]> * Update statesync.bash (#1208) * Update statesync.bash This config should only use seeds, and shouldn't have a persistent peer * Update statesync.bash having several rpcs is better than depending on one Co-authored-by: billy rennekamp <[email protected]> * build: bump liquidity to v1.4.4 from v1.4.2 (#1210) * build: bump liquidity to v1.4.4-rc1 from v1.4.2 * build: bump liquidity to v1.4.4 * Bump github.com/cosmos/ibc-go/v2 from 2.0.2 to 2.0.3 (#1231) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.3/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: billy rennekamp <[email protected]> * Fix rocksdb build tag usage (#1135) * this paves the way for widespread rocksdb usage * rocksdb * Use latest cosmos/gorocksdb * Delete .gitpod.yml gitpod has been adding these.... don't want it of course. * go mod tidy Co-authored-by: billy rennekamp <[email protected]> * 1159 update state sync configs (#1160) * Update default snapshot configs * Refactor * Fix override to include default template Co-authored-by: billy rennekamp <[email protected]> * Bump github.com/tendermint/tm-db from 0.6.4 to 0.6.6 (#1116) Bumps [github.com/tendermint/tm-db](https://github.com/tendermint/tm-db) from 0.6.4 to 0.6.6. - [Release notes](https://github.com/tendermint/tm-db/releases) - [Changelog](https://github.com/tendermint/tm-db/blob/master/CHANGELOG.md) - [Commits](tendermint/tm-db@v0.6.4...v0.6.6) --- updated-dependencies: - dependency-name: github.com/tendermint/tm-db dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marko <[email protected]> * tm-db version 0.6.4 * chore: update changelog Co-authored-by: Mariya <[email protected]> Co-authored-by: billy rennekamp <[email protected]> Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: dongsam <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: lg <[email protected]> Co-authored-by: Marko <[email protected]>

* this paves the way for widespread rocksdb usage * rocksdb * Use latest cosmos/gorocksdb * Delete .gitpod.yml gitpod has been adding these.... don't want it of course. * go mod tidy Co-authored-by: billy rennekamp <[email protected]>

* build: bump liquidity to v1.4.6 from v1.4.4(unusable) (#1308) * R4R: Update reproducible build command (#1278) * Update reproducible build command to use latest reproducible build docker image from https://github.com/tendermint/images which is published on the tendermintdev dockerhub account * Update RELEASING.md * Update RELEASING.md * Update join-mainnet.md * R4R: chore: update changelog (#1275) * chore: update changelog * add back v5.0.8 to changelog * add back v5.0.8 to changelog * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: yaruwangway <[email protected]> * Update CHANGELOG.md Co-authored-by: yaruwangway <[email protected]> Co-authored-by: yaruwangway <[email protected]> * Release/v6.0.1 (#1255) * app.toml template gRPCWeb port conflict fix (#1230) Co-authored-by: billy rennekamp <[email protected]> * Update statesync.bash (#1208) * Update statesync.bash This config should only use seeds, and shouldn't have a persistent peer * Update statesync.bash having several rpcs is better than depending on one Co-authored-by: billy rennekamp <[email protected]> * build: bump liquidity to v1.4.4 from v1.4.2 (#1210) * build: bump liquidity to v1.4.4-rc1 from v1.4.2 * build: bump liquidity to v1.4.4 * Bump github.com/cosmos/ibc-go/v2 from 2.0.2 to 2.0.3 (#1231) Bumps [github.com/cosmos/ibc-go/v2](https://github.com/cosmos/ibc-go) from 2.0.2 to 2.0.3. - [Release notes](https://github.com/cosmos/ibc-go/releases) - [Changelog](https://github.com/cosmos/ibc-go/blob/v2.0.3/CHANGELOG.md) - [Commits](cosmos/ibc-go@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: github.com/cosmos/ibc-go/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: billy rennekamp <[email protected]> * Fix rocksdb build tag usage (#1135) * this paves the way for widespread rocksdb usage * rocksdb * Use latest cosmos/gorocksdb * Delete .gitpod.yml gitpod has been adding these.... don't want it of course. * go mod tidy Co-authored-by: billy rennekamp <[email protected]> * 1159 update state sync configs (#1160) * Update default snapshot configs * Refactor * Fix override to include default template Co-authored-by: billy rennekamp <[email protected]> * Bump github.com/tendermint/tm-db from 0.6.4 to 0.6.6 (#1116) Bumps [github.com/tendermint/tm-db](https://github.com/tendermint/tm-db) from 0.6.4 to 0.6.6. - [Release notes](https://github.com/tendermint/tm-db/releases) - [Changelog](https://github.com/tendermint/tm-db/blob/master/CHANGELOG.md) - [Commits](tendermint/tm-db@v0.6.4...v0.6.6) --- updated-dependencies: - dependency-name: github.com/tendermint/tm-db dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marko <[email protected]> * tm-db version 0.6.4 * chore: update changelog Co-authored-by: Mariya <[email protected]> Co-authored-by: billy rennekamp <[email protected]> Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: dongsam <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: lg <[email protected]> Co-authored-by: Marko <[email protected]> * Fix rocksdb build tag usage (#1135) * this paves the way for widespread rocksdb usage * rocksdb * Use latest cosmos/gorocksdb * Delete .gitpod.yml gitpod has been adding these.... don't want it of course. * go mod tidy Co-authored-by: billy rennekamp <[email protected]> * versions (#1100) * Updates to core cosmos library versions * tidy * Version bumps * Fix home flag Co-authored-by: billy rennekamp <[email protected]> * replace strangelove packetmiddleware to ibc v2.0.3 compatible Co-authored-by: dongsam <[email protected]> Co-authored-by: yaruwangway <[email protected]> Co-authored-by: Mariya <[email protected]> Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: lg <[email protected]> Co-authored-by: Marko <[email protected]>

this paves the way for widespread rocksdb usage

ea78cf8

faddat requested review from alexanderbez, cmwaters, jackzampolin, jgimeno, okwme, yaruwangway and zmanian as code owners December 28, 2021 01:52

faddat changed the title ~~this paves the way for widespread rocksdb usage~~ Fix rocksdb build tag usage Dec 28, 2021

tac0turtle approved these changes Dec 28, 2021

View reviewed changes

rocksdb

4cae6e0

faddat added 2 commits January 16, 2022 17:06

Use latest cosmos/gorocksdb

ff83cb9

Delete .gitpod.yml

cbfddad

gitpod has been adding these.... don't want it of course.

okwme approved these changes Jan 19, 2022

View reviewed changes

okwme and others added 2 commits January 19, 2022 19:13

Merge branch 'main' into rocksdb

11cf6d4

Merge branch 'main' into rocksdb

6fbb76f

zmanian approved these changes Jan 22, 2022

View reviewed changes

faddat added 2 commits January 28, 2022 01:29

Merge branch 'main' into rocksdb

71afc58

Merge branch 'main' into rocksdb

5c23575

okwme and others added 3 commits January 31, 2022 14:03

Merge branch 'main' into rocksdb

45f7ba6

Merge branch 'main' into rocksdb

d77384a

go mod tidy

1827e40

okwme approved these changes Feb 1, 2022

View reviewed changes

okwme merged commit 4aea416 into cosmos:main Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix rocksdb build tag usage #1135

Fix rocksdb build tag usage #1135

faddat commented Dec 28, 2021 •

edited

Loading

zmanian commented Dec 28, 2021

zmanian commented Dec 28, 2021

codecov bot commented Dec 28, 2021 •

edited

Loading

faddat commented Dec 28, 2021 •

edited

Loading

faddat commented Dec 28, 2021

faddat commented Dec 28, 2021

tac0turtle left a comment

faddat commented Jan 2, 2022 •

edited

Loading

okwme commented Jan 12, 2022

tac0turtle commented Jan 12, 2022

faddat commented Jan 16, 2022 •

edited

Loading

zmanian commented Jan 19, 2022

Fix rocksdb build tag usage #1135

Fix rocksdb build tag usage #1135

Conversation

faddat commented Dec 28, 2021 • edited Loading

zmanian commented Dec 28, 2021

zmanian commented Dec 28, 2021

codecov bot commented Dec 28, 2021 • edited Loading

Codecov Report

faddat commented Dec 28, 2021 • edited Loading

faddat commented Dec 28, 2021

faddat commented Dec 28, 2021

tac0turtle left a comment

Choose a reason for hiding this comment

faddat commented Jan 2, 2022 • edited Loading

okwme commented Jan 12, 2022

tac0turtle commented Jan 12, 2022

faddat commented Jan 16, 2022 • edited Loading

zmanian commented Jan 19, 2022

faddat commented Dec 28, 2021 •

edited

Loading

codecov bot commented Dec 28, 2021 •

edited

Loading

faddat commented Dec 28, 2021 •

edited

Loading

faddat commented Jan 2, 2022 •

edited

Loading

faddat commented Jan 16, 2022 •

edited

Loading