app.go cleanup (#1580)

* Initial creation of blobs

* Add upgrades dir with v8 rho upgrade

* Remove module.go for keeper package

* Remove repeated comment

* Add newline in constants.go file

* Remove unused commented out code

* Fix linted

* Fix import grouping

* Fix import grouping for module and upgrades

* Fix initialization of ica module

* Empty commit for actions trigger

* Move upgrade function from v8 to v7, create empty v8 upgrade files

* Add v8 upgrade handler to app.go

* Ignore const, keys and modules.go files from codecov

* Ignore app params as well since there are no tests required for it

* Restructure ordering of ignoring files and add a Todo commands

* Comment out TestAccAddress function for linters to pass

* Remove previously added ignore files from codecov, since they have no impact

Co-authored-by: billy rennekamp <[email protected]>
Co-authored-by: Danilo Pantani <[email protected]>

app/const.go

@@ -1,34 +1,5 @@
 package gaia
 
 const (
-	appName     = "GaiaApp"
-	upgradeName = "v8-Rho"
-
-	// allowed msg types of ica host
-	authzMsgExec                        = "/cosmos.authz.v1beta1.MsgExec"
-	authzMsgGrant                       = "/cosmos.authz.v1beta1.MsgGrant"
-	authzMsgRevoke                      = "/cosmos.authz.v1beta1.MsgRevoke"
-	bankMsgSend                         = "/cosmos.bank.v1beta1.MsgSend"
-	bankMsgMultiSend                    = "/cosmos.bank.v1beta1.MsgMultiSend"
-	distrMsgSetWithdrawAddr             = "/cosmos.distribution.v1beta1.MsgSetWithdrawAddress"
-	distrMsgWithdrawValidatorCommission = "/cosmos.distribution.v1beta1.MsgWithdrawValidatorCommission"
-	distrMsgFundCommunityPool           = "/cosmos.distribution.v1beta1.MsgFundCommunityPool"
-	distrMsgWithdrawDelegatorReward     = "/cosmos.distribution.v1beta1.MsgWithdrawDelegatorReward"
-	feegrantMsgGrantAllowance           = "/cosmos.feegrant.v1beta1.MsgGrantAllowance"
-	feegrantMsgRevokeAllowance          = "/cosmos.feegrant.v1beta1.MsgRevokeAllowance"
-	govMsgVoteWeighted                  = "/cosmos.gov.v1beta1.MsgVoteWeighted"
-	govMsgSubmitProposal                = "/cosmos.gov.v1beta1.MsgSubmitProposal"
-	govMsgDeposit                       = "/cosmos.gov.v1beta1.MsgDeposit"
-	govMsgVote                          = "/cosmos.gov.v1beta1.MsgVote"
-	stakingMsgEditValidator             = "/cosmos.staking.v1beta1.MsgEditValidator"
-	stakingMsgDelegate                  = "/cosmos.staking.v1beta1.MsgDelegate"
-	stakingMsgUndelegate                = "/cosmos.staking.v1beta1.MsgUndelegate"
-	stakingMsgBeginRedelegate           = "/cosmos.staking.v1beta1.MsgBeginRedelegate"
-	stakingMsgCreateValidator           = "/cosmos.staking.v1beta1.MsgCreateValidator"
-	vestingMsgCreateVestingAccount      = "/cosmos.vesting.v1beta1.MsgCreateVestingAccount"
-	ibcMsgTransfer                      = "/ibc.applications.transfer.v1.MsgTransfer"
-	liquidityMsgSwapWithinBatch         = "/tendermint.liquidity.v1beta1.MsgSwapWithinBatch" //#nosec G101 -- This is a false positive
-	liquidityMsgCreatePool              = "/tendermint.liquidity.v1beta1.MsgCreatePool"
-	liquidityMsgDepositWithinBatch      = "/tendermint.liquidity.v1beta1.MsgDepositWithinBatch"
-	liquidityMsgWithdrawWithinBatch     = "/tendermint.liquidity.v1beta1.MsgWithdrawWithinBatch"
+	appName = "GaiaApp"
 )

app/export.go

@@ -161,7 +161,7 @@ func (app *GaiaApp) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs [
 
 	// Iterate through validators by power descending, reset bond heights, and
 	// update bond intra-tx counters.
-	store := ctx.KVStore(app.keys[stakingtypes.StoreKey])
+	store := ctx.KVStore(app.GetKey(stakingtypes.StoreKey))
 	iter := sdk.KVStoreReversePrefixIterator(store, stakingtypes.ValidatorsKey)
 	counter := int16(0)