docs(adr): ADR-045: BaseApp {Check,Deliver}Tx as Middlewares

[amaury1093]

Description

rendered

Closes: #9953

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[orijbot]

Visit https://dashboard.github.orijtech.com?back=0&pr=9996&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details.

[amaury1093]

given the diagram, do you think ComposeMiddlewares(H, A, B, C) is clearer or ComposeMiddlewares(H, C, B, A)?

[jgimeno]

I think ComposeMiddlewares(H, C, B, A) is easier to point that it goes from the inner layer up to the outer one.

[tac0turtle]

nicely written, thank you!

[amaury1093]

@aaronc since you're on the ADR reviewing committee, would you like to give the final approval before merge?

[aaronc]

Good work @AmauryM 🎉