chore: Update STABLE_RELEASES for 0.43 #9931
Conversation
| * Breaking changes in Protobuf definitions, as specified in [ADR-044](./docs/architecture/adr-044-protobuf-updates-guidelines.md). | ||
| * Changes that introduces API breakages (e.g. public functions and interfaces removal/renaming). | ||
| * Client-breaking changes in gRPC and HTTP request and response types. | ||
| * CLI-breaking changes. |
There was a problem hiding this comment.
We didn't decide if we're okay to backport CLI-breaking changes. I've heard both opinions, for and against.
My personal opinion is to forbid backporting CLI-breaking changes.
There was a problem hiding this comment.
I think lines 72, and 70 should have an exception carved out explicitly in the case of bugs
There was a problem hiding this comment.
@ValarDragon The way it's framed right now, 70-72 are breaking changes that should not go in a "Stable Release Update".
In case of breaking bugs, they are handled by SRE:
In some circumstances, PRs that don't meet the aforementioned criteria might be raised and asked to be granted a Stable Release Exception.
** describe Stable Release Exception **
amaury1093
changed the title
|
ping @robert-zaremba, would also like you to have a look |
|
Visit https://dashboard.github.orijtech.com?pr=9931&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
(cherry picked from commit e0096c2)
| @@ -58,43 +58,53 @@ To smoothen the update to the latest stable release, the SDK includes a set of C | |||
| * Bugs that may cause **loss of user's data**. | |||
| * Other safe cases: | |||
| * Bugs which don't fit in the aforementioned categories for which an obvious safe patch is known. | |||
| * Relatively small yet strictly non-breaking features with strong support from the community. | |||
There was a problem hiding this comment.
very good framing 👍
Description
Closes: #9116
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change