Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add jq doc for editing genesis file #9918

Merged
merged 9 commits into from
Aug 16, 2021
Merged

docs: add jq doc for editing genesis file #9918

merged 9 commits into from
Aug 16, 2021

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Aug 12, 2021

Description

Closes: #9908


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp marked this pull request as ready for review August 12, 2021 08:08
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/run-node/run-node.md Outdated Show resolved Hide resolved
@amaury1093 amaury1093 changed the title feat!: add jq doc docs: add jq doc for editing genesis file Aug 12, 2021
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I believe providing a list of jq and sed commands to override some default settings would be handy. Like exposing grpc, rosetta, inflation, voting_period etc.

docs/run-node/run-node.md Outdated Show resolved Hide resolved
@orijbot
Copy link

orijbot commented Aug 13, 2021

docs/run-node/run-node.md Show resolved Hide resolved
@amaury1093
Copy link
Contributor

Looks good! @atheeshp feel free to put automerge once my last review is addressed

@atheeshp atheeshp added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 16, 2021
@mergify mergify bot merged commit 3022865 into master Aug 16, 2021
@mergify mergify bot deleted the atheesh/jq-doc branch August 16, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add jq command to help users in editing json
6 participants