-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/gov: allow arbitrary messages in proposal #9726
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,13 +32,14 @@ message MsgSubmitProposal { | |
option (gogoproto.stringer) = false; | ||
option (gogoproto.goproto_getters) = false; | ||
|
||
google.protobuf.Any content = 1 [(cosmos_proto.accepts_interface) = "Content"]; | ||
google.protobuf.Any content = 1 [deprecated = true, (cosmos_proto.accepts_interface) = "Content"]; | ||
repeated cosmos.base.v1beta1.Coin initial_deposit = 2 [ | ||
(gogoproto.nullable) = false, | ||
(gogoproto.castrepeated) = "github.com/cosmos/cosmos-sdk/types.Coins", | ||
(gogoproto.moretags) = "yaml:\"initial_deposit\"" | ||
]; | ||
string proposer = 3; | ||
string proposer = 3; | ||
repeated google.protobuf.Any messages = 4; | ||
} | ||
|
||
// MsgSubmitProposalResponse defines the Msg/SubmitProposal response type. | ||
|
@@ -91,3 +92,15 @@ message MsgDeposit { | |
|
||
// MsgDepositResponse defines the Msg/Deposit response type. | ||
message MsgDepositResponse {} | ||
|
||
// MsgSignal is a simple text-based message that can be added to a proposal if | ||
// the proposer wants to signal a change. Nothing is executed. | ||
message MsgSignal { | ||
option (gogoproto.equal) = true; | ||
option (gogoproto.goproto_stringer) = false; | ||
option (gogoproto.stringer) = false; | ||
option (gogoproto.goproto_getters) = false; | ||
|
||
string title = 1; | ||
string description = 2; | ||
} | ||
Comment on lines
+98
to
+106
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we just add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's the alternative to adding a signal message in the proposal. I wasn't sure if all proposals necessary needed a title and a description. In some cases a link/address that points to the forum / proposal write up might suffice There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think a link is more common and maybe a better idea. We should discuss. I don't think the title and description metadata should extend to group proposals for a number of reasons. Some groups may be want to be more anonymous and including title and description could confuse users into sharing private info on a public blockchain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.