fix: query txs command adds output flag #9540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengwenxi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9540 +/- ##
=======================================
Coverage 60.58% 60.59%
=======================================
Files 589 589
Lines 37228 37217 -11
=======================================
- Hits 22556 22550 -6
+ Misses 12728 12723 -5
Partials 1944 1944
|
amaury1093
reviewed
Jun 18, 2021
alexanderbez
approved these changes
Jun 18, 2021
amaury1093
reviewed
Jun 18, 2021
| @@ -198,8 +198,7 @@ $ %s query txs --%s 'message.sender=cosmos1...&message.action=withdraw_delegator | |||
| }, | |||
| } | |||
|
|
|||
| cmd.Flags().StringP(flags.FlagNode, "n", "tcp://localhost:26657", "Node to connect to") | |||
| cmd.Flags().String(flags.FlagKeyringBackend, flags.DefaultKeyringBackend, "Select keyring's backend (os|file|kwallet|pass|test)") | |||
There was a problem hiding this comment.
Technically speaking removing --keyring-backend is a client-breaking change, so should wait RC before getting merged.
However, I agree with @chengwenxi that this flag is non-sensical here, and I'm pretty sure no-one uses it. So I'm actually okay to merge this PR. Any strong opinions @robert-zaremba and @ryanchristo ?
There was a problem hiding this comment.
I think it would be safe to merge. Not sure how one would use it in this situation anyways.
amaury1093
added
backport/0.42.x (Stargate)
and removed
backport/0.42.x (Stargate)
labels
amaury1093
approved these changes
Jun 21, 2021
amaury1093
added
the
A:automerge
56 tasks
9 tasks
ValarDragon
pushed a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Jul 5, 2021
ValarDragon
pushed a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Jul 9, 2021
ValarDragon
pushed a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Aug 3, 2021
ValarDragon
pushed a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Aug 5, 2021
faddat
pushed a commit
to notional-labs/cosmos-sdk
that referenced
this pull request
Jan 4, 2023
faddat
pushed a commit
to notional-labs/cosmos-sdk
that referenced
this pull request
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Query txscommand addsoutputflag, to make it consistent with other query commands.Delete unused flag
keyring-backend.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change