Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Fix IBC helper func QueryTMProof #9434

Closed
wants to merge 1 commit into from

Conversation

colin-axner
Copy link
Contributor

Description

Waiting to verify fix via passing tests on relayer but still running into tm light client issues

ref: #9433
closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@colin-axner colin-axner marked this pull request as draft June 1, 2021 11:21
@tac0turtle
Copy link
Member

@colin-axner is this still applicable?

@colin-axner
Copy link
Contributor Author

@colin-axner is this still applicable?

yea, it is just untested. I'm almost certain it is correct, but the main user of this function is the go relayer and when I applied the fix, I ran into a ton of other issues on the go relayer that require a significant refactor. Given that hermes and the ts-relayer function fine, testing this moved lower down on my priority list

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 2, 2021
@colin-axner
Copy link
Contributor Author

closing for now, until the fix is tested this doesn't need to be open. I'm still aware of this issue and will ensure the fix is applied when necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants