chore: add markdownlint to lint commands

[ryanchristo]

Description

This pull request adds markdownlint to the lint commands defined in Makefile.

• make lint will now report issues with markdown files
• make lint-fix will now attempt to fix issues with markdown files

The configuration for markdownlint was originally copied from tendermint (see markdownlint.yml) and then modified to include additional rules to help limit the scope of this pull request.

• .markdownlint.json and .markdownlintignore set the configuration
• docs/basics/app-anatomy.md was updated manually for a missing link
• the remaining files were updated using the make lint-fix command

closes: #8112

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards. - n/a
• Wrote unit and integration tests - n/a
• Updated relevant documentation (docs/) or specification (x/<module>/spec/) - n/a
• Added relevant godoc comments. - n/a
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md - n/a
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes - n/a

[alexanderbez]

Thanks for doing this. I love this extension and I've been using it for a long time.

[robert-zaremba]

Had a chat with @ryanchristo . The default Markdown lint yields lot of errors, and many of them are are not auto fixable.
I suggest to create a config which won't yield many not auto fixable errors, and optionally later on we can update the config and fix other linter errors.

[ryanchristo]

The default Markdown lint yields lot of errors, and many of them are are not auto fixable.

For clarification, we are using the same configuration as tendermint, not the default configuration.

I suggest to create a config which won't yield many not auto fixable errors, and optionally later on we can update the config and fix other linter errors.

It would be nice if we did not alter the configuration because it is currently the same configuration for tendermint but this would be one way to break up the work. I don't mind going through and fixing all the lint warnings if this needs to be done but it will be a lot of changes for one pull request so I just wanted to double check with others before moving forward.

[amaury1093]

I'm fine with a 3k line diff in this PR, but maybe the commits could be well separated into 1/ auto-fix and 2/ manual fixes, to make the review easier (the reviewer can run auto-fix locally, and just review the manual fixes, and make sure the output diff is the same as this PR's)

(also want to be respectful of Ryan doing a lot of repetitive chore work, if there's too much work for one PR, we can consider muting some lints for now and doing multiple PRs).

[robert-zaremba]

If you want to manually fix few thousands lines of code then fair enough 💪 Just wanted to point that it's not very important.

[ryanchristo]

I'm definitely reevaluating after further reviewing the warnings and changes. I'm also unsure about a couple configuration options such as the addition of angle brackets around links. I'm going to explore your initial suggestions @robert-zaremba. Thanks!

[ryanchristo]

@marbar3778 I'm receiving the following error with the Atlas checks:

Run marbar3778/atlas_action@main

...

failed to publish module: {"error":"failed to query user token: record not found"}

Any ideas?

[amaury1093]

lgtm

[robert-zaremba]

Good job.
If there is any follow up task (eg to change some rules), then let's create an issue for it.

[amaury1093]

i was goingi to put automerge, but saw atlas failing. Do we want to fix that before merging? cc @alexanderbez @marbar3778

[ryanchristo]

i was goingi to put automerge, but saw atlas failing. Do we want to fix that before merging? cc @alexanderbez @marbar3778

I messaged @marbar3778 in Discord and he said he was looking into this but it does not need to be solved before merging. It should be safe to add automerge.

[tac0turtle]

yea feel free to merge. I need to dive into it.