Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: ADR-043 Base NFT Module #9329
docs: ADR-043 Base NFT Module #9329
Changes from 17 commits
8701e97
3876262
6c923d3
bdb6005
af68935
be60788
1759155
96f9e11
09c17a6
13cc5a2
435c219
1571a59
1f3ec2a
b5a36b3
835b581
e39f059
e8e6980
db8bd84
cc289b6
3f7c8bb
1098e27
55ebf53
9b4f4cf
0849698
ccb2807
278507b
8004004
51df217
5e2f4c3
f1e81fa
899e2a2
b641f4c
9d60dfd
0dbfbdb
c8642f4
5152044
0092c53
843f79c
c98ce3a
013e9ca
8891fa2
836580a
afc6680
121dff1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Protobuf
Msg
service is preferred to specify all transaction methods. Please defineMsg
service with all RPC methods, as you definedQuery
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only define this method in the keeper to execute common logic without a
Msg
, theMsg
should be defined in the upper-level/app-specific specific module.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Protobuf service oriented architecture (which we are using since Stargate), we are exposing module interfaces through Protobuf services. Keeper is rather used as an internal data access layer (however, often protobuf and keeper are implemented by the same object -> keeper, but module user doesn't see it).
So, since Stargate we want to use Proto definitions for module interface, and Keeper if you want to talk about internal data layout in the store.
See ADR-30 (authz module) for an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I got it.
I will update this ADR after learning about ADR-30 and ADR-33.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ADR-33 is still in active development. I think ADR-30 will give you a good example. Also, as mentioned in other comment, for events please look at ADR-32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an SDK ADR, so I think we should more focus on the Cosmos ecosystem here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ###
Msg
Service section we define methods.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those extensions or new modules? How this will work? Will there be a new services in the
nft
module?