-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initialize module x/nft #9174
Conversation
Thank you for opening this PR. I would love to see this be the first item that goes through the newly established CIP process since it may live on the hub. @ebuchman what do you think? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Visit https://dashboard.github.orijtech.com?pr=9174&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
Looks like there are some linting errors that came up from
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please have this broken up into smaller PRs? It is really hard to do good reviews of such large pieces of work all at once.
I would suggest individual PRs roughly in this order:
- just the .proto files
- just the MsgServer implementation and corresponding keeper methods
- just the QueryServer implementation and corresponding keeper methods
- CLI
- simulations
Good suggestion, We will split into several PRs to this branch(
|
Thanks! Please make PRs against master if you want the SDK team to review. |
I created issue #9826 to track the nft related PRs, so I closed it. |
Summary
Implements ADR-043-nft.
A generic module to store NFTs based on discussion #9065 and PR #9329.
x/nft
only storesNFTs
by id and owner. NFT contains a data field as aproto.Any
.data
field CAN be used by composing modules to specify additional properties for the NFT to support their own use cases, such as ERC721 transferred from Ethereum through the Gravity bridge.