x/auth new test - multisig tx on simulate endpoint #9038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technicallyty
requested review from
aaronc,
alessio and
alexanderbez
as code owners
technicallyty
changed the title
-cleanup imports
amaury1093
added
the
A:automerge
|
@technicallyty the failing test seems related to the PR |
4 tasks
Turns out one of the other tests was causing the accounts to not exist anymore? I moved the account creation into the test and it works now. |
Codecov Report
@@ Coverage Diff @@
## master #9038 +/- ##
==========================================
+ Coverage 58.95% 58.99% +0.04%
==========================================
Files 575 575
Lines 32191 32198 +7
==========================================
+ Hits 18977 18996 +19
+ Misses 10999 10985 -14
- Partials 2215 2217 +2
|
sahith-narahari
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a test for a multisig tx to the simulation endpoint. Currently there are no tests with multisig tx on simulate endpoint.
Motivation: Issue where developer could not successfully call calculate gas with a multisig due to txFactory shortcomings. This test serves to address that issue by presenting an alternative method to calculating gas with a multisig tx by calling the simulate endpoint.
ref: #8821
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes