Add ledger/multisig detection in SignTx functions #9026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
commented
Mar 30, 2021
Comment on lines
+71
to
+72
| // This function should only be used when signing with a multisig. For | ||
| // normal keys, please use SignTx directly. |
There was a problem hiding this comment.
This function is called twice in the sdk, and both are with multisigs. As I understand, there's no use-case for calling this without a multisig, correct?
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #9026 +/- ##
==========================================
- Coverage 58.96% 58.85% -0.11%
==========================================
Files 575 573 -2
Lines 32159 32091 -68
==========================================
- Hits 18963 18888 -75
- Misses 10982 10992 +10
+ Partials 2214 2211 -3
|
amaury1093
commented
Mar 30, 2021
amaury1093
requested review from
aaronc,
alessio and
alexanderbez
as code owners
alessio
approved these changes
Mar 30, 2021
amaury1093
added a commit
that referenced
this pull request
Apr 1, 2021
* Add ledger/multisig detection in SignTx functions * Fix tests * Update CHANGELOG.md * update cl Co-authored-by: Alessio Treglia <[email protected]>
9 tasks
alessio
pushed a commit
that referenced
this pull request
Apr 1, 2021
…9041) Co-authored-by: Alessio Treglia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before:
Some individual commands (
tx sign,tx sign-batch) hardcoded to useSIGN_MODE_LEGACY_AMINO_JSONin the CLI command handler.We forgot to hardcode
SIGN_MODE_LEGACY_AMINO_JSONin the gentx command, hence the bug #9023After:
Instead of putting the code:
if txF.SignMode == nil {txF.WithSignMode(LEGACY_AMINO_JSON)}in each individual CLI command, we factorize that in the upstream
.SignTxand.SignTxWithAddressfunctions that the CLI calls.I tested
simd gentxwith a ledger keycloses: #9023
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes