Dump all state to JSON #901

cwgoes · 2018-04-23T12:51:59Z

Closes #131

codecov · 2018-04-23T12:55:52Z

Codecov Report

Merging #901 into develop will decrease coverage by 2.18%.
The diff coverage is 30.18%.

@@             Coverage Diff             @@
##           develop     #901      +/-   ##
===========================================
- Coverage    62.61%   60.42%   -2.19%     
===========================================
  Files           65       72       +7     
  Lines         3314     3500     +186     
===========================================
+ Hits          2075     2115      +40     
- Misses        1072     1215     +143     
- Partials       167      170       +3

cwgoes · 2018-04-26T16:01:26Z

Swapped to general export command, so usage would be like:

gaiad export > ~/.gaiad/config/genesis.json
# modify some consensus rules, rebuild
gaiad start

cwgoes · 2018-04-26T17:00:21Z

Ready for review, the code coverage isn't very accurate & this isn't consensus-level anyways.

Thoughts on this approach / alternative suggestions welcome.

rigelrozanski · 2018-04-26T17:36:42Z

x/stake/keeper.go

@@ -371,6 +371,30 @@ func (k Keeper) GetDelegatorBond(ctx sdk.Context,
 	return bond, true
 }

+// load all bonds
+func (k Keeper) GetBonds(ctx sdk.Context, maxRetrieve int16) (bonds []DelegatorBond) {


Does this need to be exposed? I don't think we need to use this outside of specialized stake functionality

Nope, now unexposed.

rigelrozanski · 2018-04-26T17:37:36Z

x/stake/handler.go

@@ -49,9 +49,29 @@ func NewEndBlocker(k Keeper) sdk.EndBlocker {
 //_____________________________________________________________________

 // InitGenesis - store genesis parameters
-func InitGenesis(ctx sdk.Context, k Keeper, data GenesisState) {
+func (k Keeper) InitGenesis(ctx sdk.Context, data GenesisState) {


InitGenesis (and WriteGenesis now) should not be functions of the keeper. It's subtle, but a while back Jae and I came the conclusion that handler ought to not be a function of keeper, by extension I'd put genesis functionality in the same category

rigelrozanski · 2018-04-26T20:15:13Z

cmd/gaia/app/app.go

@@ -149,7 +149,15 @@ func (app *GaiaApp) initChainer(ctx sdk.Context, req abci.RequestInitChain) abci
 	}

 	// load the initial stake information
-	stake.InitGenesis(ctx, app.stakeKeeper, genesisState.StakeData)
+	stake.InitGenesis(app.stakeKeeper, ctx, genesisState.StakeData)


why did you switch it's standard that the context is always the first function input

OK, updated all instances.

rigelrozanski · 2018-04-26T20:18:42Z

cmd/gaia/cmd/gaiad/main.go

+	if err != nil {
+		return nil, nil, err
+	}
+	bapp := app.NewGaiaApp(log.NewNopLogger(), db)


bapp -> gapp

rigelrozanski · 2018-04-26T20:20:03Z

cmd/gaia/cmd/gaiad/main.go

+	}
+	bapp := app.NewGaiaApp(log.NewNopLogger(), db)
+	if err != nil {
+		return nil, nil, err


This error check is not checking any new errors :P

Oops, too much vim-copy-search-replace fu. Fixed.

rigelrozanski · 2018-04-26T20:23:25Z

cmd/gaia/cmd/gaiad/main.go

@@ -39,3 +40,16 @@ func generateApp(rootDir string, logger log.Logger) (abci.Application, error) {
 	bapp := app.NewGaiaApp(logger, db)
 	return bapp, nil
 }
+
+func exportApp(rootDir string, logger log.Logger) (interface{}, *wire.Codec, error) {


I just reviewed all the instances of exportApp in this PR and I think that we should be able to move it's functionality to baseapp - we should probably really limit/group what is actually being passed into server.AddCommands that list is growing fast, I think we just pass in the app which extends baseapp and therefore should have access to exportApp if we build it into their. - We could do this refactors as in this PR or in a separate PR I guess

I agree, I'll do this in this PR.

Reworked generateApp and baseApp to share common functionality, let me know what you think.

rigelrozanski

Looking good - I think we should refactor to bring exportApp into baseapp as I mentioned in one of my comments

cwgoes · 2018-04-27T15:09:26Z

Addressed PR comments and added an iterator to export accounts properly. Testsuite presently fails, I think because the account mapper no longer uses the main store.

Addressed, see comment

cwgoes · 2018-04-27T15:21:25Z

Testcases fixed, just needed to change some store names.

Curious if there was a reason accounts were using the main store, or if it was just unintentional?

edit: Per conversation, seems to be unintentional & using a separate store is the right approach.

rigelrozanski

nice work

cwgoes requested a review from ebuchman as a code owner April 23, 2018 12:52

cwgoes force-pushed the cwgoes/dump-state-to-json branch 2 times, most recently from 00d1b15 to 744a1e9 Compare April 26, 2018 15:53

cwgoes changed the title ~~WIP: Dump all state to JSON~~ Dump all state to JSON Apr 26, 2018

cwgoes requested a review from rigelrozanski April 26, 2018 17:12

rigelrozanski reviewed Apr 26, 2018

View reviewed changes

cwgoes force-pushed the cwgoes/dump-state-to-json branch from a20ac0d to 6d0c313 Compare April 26, 2018 19:34

rigelrozanski reviewed Apr 26, 2018

View reviewed changes

rigelrozanski previously requested changes Apr 26, 2018

View reviewed changes

cwgoes changed the title ~~Dump all state to JSON~~ WIP: Dump all state to JSON Apr 26, 2018

cwgoes changed the title ~~WIP: Dump all state to JSON~~ Dump all state to JSON Apr 27, 2018

cwgoes added 9 commits April 27, 2018 20:00

Example WriteGenesis implementation

ff66629

Add simple WriteGenesis for stake & cool modules

f71191e

Add candidates & bonds to stake module genesis

0436d89

Add export command to stake module

203d2c1

export-stake command works

55c82e4

Swap to general export command

f92e83d

Minor cleanup

724c1ec

Add testcases

9746260

Minor bugfix

88b364d

cwgoes and others added 10 commits April 27, 2018 20:03

Test GetBonds

dbdf6aa

GetBonds => getBonds

c788c3e

InitGenesis & WriteGenesis no longer functions of keepers

9450779

Rebase & merge changes

df4fdb3

Reorder parameters & remove redundant check

f6cef02

Move generateApp & exportApp to baseapp/helpers

10d2e5a

Add IterateAccounts & account export

ad77aff

Use account store key

5759f6a

Fix testsuite

6796147

refactor export function, working

10ddd7a

rigelrozanski force-pushed the cwgoes/dump-state-to-json branch from c67c98f to 10ddd7a Compare April 28, 2018 00:07

rigelrozanski and others added 3 commits April 27, 2018 20:36

refactor

318e924

export refactor, lcd tests borken

f7587f7

Fix testcase

81ac153

rigelrozanski approved these changes Apr 28, 2018

View reviewed changes

rigelrozanski merged commit 71dccd4 into develop Apr 28, 2018

rigelrozanski deleted the cwgoes/dump-state-to-json branch April 28, 2018 00:57

cwgoes mentioned this pull request May 1, 2018

Dump state and restart #131

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dump all state to JSON #901

Dump all state to JSON #901

cwgoes commented Apr 23, 2018 •

edited

Loading

codecov bot commented Apr 23, 2018 •

edited

Loading

cwgoes commented Apr 26, 2018

cwgoes commented Apr 26, 2018

rigelrozanski Apr 26, 2018

cwgoes Apr 26, 2018

rigelrozanski Apr 26, 2018

cwgoes Apr 26, 2018

rigelrozanski Apr 26, 2018

cwgoes Apr 26, 2018

rigelrozanski Apr 26, 2018

cwgoes Apr 26, 2018

rigelrozanski Apr 26, 2018

cwgoes Apr 26, 2018

rigelrozanski Apr 26, 2018

cwgoes Apr 26, 2018

cwgoes Apr 27, 2018

rigelrozanski left a comment

cwgoes commented Apr 27, 2018

cwgoes commented Apr 27, 2018 •

edited

Loading

rigelrozanski left a comment

Dump all state to JSON #901

Dump all state to JSON #901

Conversation

cwgoes commented Apr 23, 2018 • edited Loading

codecov bot commented Apr 23, 2018 • edited Loading

Codecov Report

cwgoes commented Apr 26, 2018

cwgoes commented Apr 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rigelrozanski left a comment

Choose a reason for hiding this comment

cwgoes commented Apr 27, 2018

cwgoes commented Apr 27, 2018 • edited Loading

rigelrozanski left a comment

Choose a reason for hiding this comment

cwgoes commented Apr 23, 2018 •

edited

Loading

codecov bot commented Apr 23, 2018 •

edited

Loading

cwgoes commented Apr 27, 2018 •

edited

Loading