Remove IBC from the SDK #8735

colin-axner · 2021-03-01T14:27:59Z

Description

The IBC module is being moved to cosmos/ibc-go

closes: #8501

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

colin-axner · 2021-03-01T15:02:56Z

I will leave the docs for now. Doesn't hurt to have documentation in multiple places

colin-axner · 2021-03-01T17:24:26Z

x/capability/keeper/keeper_test.go

@@ -114,16 +114,6 @@ func (suite *KeeperTestSuite) TestNewCapability() {
 	suite.Require().Nil(cap)
 }

-func (suite *KeeperTestSuite) TestOriginalCapabilityKeeper() {


@AdityaSripal should I replace this test with something? If so, how?

Ahh this is testing the original capability keeper in simapp since that was holding a capability for transfer. Now that simapp no longer does that, we don't need this test.

I would remove it.

colin-axner · 2021-03-01T17:25:16Z

x/auth/client/rest/rest_test.go

@@ -497,83 +436,6 @@ func (s *IntegrationTestSuite) testQueryIBCTx(txRes sdk.TxResponse, cmd *cobra.C
 	s.Require().Contains(errResp.Error, errMsg)
 }

-// TestLegacyRestErrMessages creates two IBC txs, one that fails, one that


@AmauryM how should I deal with these tests? Should I open an issue? Comment them out? Replace the IBC parts somehow?

afaik it's only one test. If you're okay to move this one test to the IBC repo, that'd be ideal. If not, then just create an issue and we'll figure out later.

I think there are a couple tests, but I'll look into moving them to the IBC repo and report back

I managed to move these over to ibc-go but it involved some code duplication since we need to route the suite setup to the ibc-go simapp.

I guess we cannot bring these tests back to the SDK until the SDK supports a Msg type that doesn't support amino and one that doesn't support REST?

colin-axner · 2021-03-02T11:53:55Z

someone will need to run proto swagger gen for me. It doesn't work on my machine for some reason

AdityaSripal

Looks good colin!

What's the strategy here? Is the idea that master will not import ibc-go? We're just going to have ibc-go imports into gaia?

AdityaSripal · 2021-03-03T15:58:53Z

simapp/app.go

@@ -64,17 +64,6 @@ import (
 	"github.com/cosmos/cosmos-sdk/x/gov"
 	govkeeper "github.com/cosmos/cosmos-sdk/x/gov/keeper"
 	govtypes "github.com/cosmos/cosmos-sdk/x/gov/types"
-	transfer "github.com/cosmos/cosmos-sdk/x/ibc/applications/transfer"


Will we be adding these back from the ibc-go repo?

ibc-go has its own simapp now. The SDK team can decide if they would like simapp to import ibc-go (after we do a stable release), but I think it isn't worth it to deal with version dependencies

AdityaSripal · 2021-03-03T16:08:26Z

x/capability/keeper/keeper_test.go

@@ -114,16 +114,6 @@ func (suite *KeeperTestSuite) TestNewCapability() {
 	suite.Require().Nil(cap)
 }

-func (suite *KeeperTestSuite) TestOriginalCapabilityKeeper() {


Ahh this is testing the original capability keeper in simapp since that was holding a capability for transfer. Now that simapp no longer does that, we don't need this test.

I would remove it.

colin-axner · 2021-03-03T16:18:29Z

What's the strategy here? Is the idea that master will not import ibc-go? We're just going to have ibc-go imports into gaia?

Correct. At least in the short term (until we have releases with ibc-go).

It seems possible to me to have a go.mod circular dependency, but probably makes things more complex (I'm not entirely sure how this works). If the SDK wanted to integrate IBC into its existing modules then we may need to add ibc-go into the go.mod, but there are probably multiple solutions here, like giving each SDK module its own go.mod file

It seems unnecessary to introduce a circular go.mod dep just for tests

colin-axner · 2021-03-04T12:32:18Z

x/auth/ante/ante_test.go

@@ -482,7 +482,8 @@ func (suite *AnteTestSuite) TestAnteHandlerFees() {
 		{
 			"signer as enough funds, should pass",
 			func() {
-				accNums = []uint64{7}
+				accNums = []uint64{acc1.GetAccountNumber()}


I think when I removed IBC registration from simapp, one less account was being created causing the account number to become 6 and not 7. I used the account associated with addr0 since that is the account being funded in this test

codecov · 2021-03-04T12:43:16Z

Codecov Report

Merging #8735 (ab27bc3) into master (eef8d4d) will decrease coverage by 2.04%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #8735      +/-   ##
==========================================
- Coverage   61.39%   59.34%   -2.05%     
==========================================
  Files         672      563     -109     
  Lines       38404    31251    -7153     
==========================================
- Hits        23577    18545    -5032     
+ Misses      12342    10551    -1791     
+ Partials     2485     2155     -330

Impacted Files	Coverage Δ
crypto/keys/secp256r1/doc.go	`60.00% <60.00%> (ø)`
crypto/keys/internal/ecdsa/pubkey.go	`69.56% <69.56%> (ø)`
crypto/keys/internal/ecdsa/privkey.go	`73.91% <73.91%> (ø)`
crypto/keys/secp256r1/pubkey.go	`76.92% <76.92%> (ø)`
crypto/keys/secp256r1/privkey.go	`80.00% <80.00%> (ø)`
simapp/app.go	`83.50% <100.00%> (-1.97%)`	⬇️
x/auth/client/rest/encode.go	`53.33% <0.00%> (-20.01%)`	⬇️
x/auth/client/rest/query.go	`28.15% <0.00%> (-10.68%)`	⬇️
x/auth/client/rest/decode.go	`41.93% <0.00%> (-9.68%)`	⬇️
x/ibc/core/simulation/decoder.go
... and 41 more

tac0turtle · 2021-03-04T13:10:52Z

😎

alessio · 2021-03-05T22:15:35Z

Hey @colin-axner! Mind updating references in github.com/cosmos/gaia (main branch), please?

colin-axner · 2021-03-08T10:27:05Z

Hey @colin-axner! Mind updating references in github.com/cosmos/gaia (main branch), please?

Yes. I presume you mean just for documentation? I cannot update the code until a release of the SDK includes IBC removed. It is my understanding that this is slated for v0.43.0 of the SDK

colin-axner added 4 commits February 22, 2021 15:41

remove IBC

baa4c66

remove ibc from simapp

2daec73

merge master

54d72bf

update README's

e7691c4

colin-axner added S:blocked Status: Blocked x/ibc labels Mar 1, 2021

update docs README

d08d452

colin-axner added 3 commits March 1, 2021 18:09

merge master

62999f8

remove auth test and run make proto-all

37a13ce

remove capability ibc test

05ce789

colin-axner commented Mar 1, 2021

View reviewed changes

fix docs README for ibc

1be3e7f

colin-axner mentioned this pull request Mar 3, 2021

Robert/addr memory leak #8717

Merged

9 tasks

AdityaSripal reviewed Mar 3, 2021

View reviewed changes

AdityaSripal approved these changes Mar 3, 2021

View reviewed changes

merge master

2b7f74a

colin-axner removed the S:blocked Status: Blocked label Mar 4, 2021

fix hardcoded test

dda7b01

colin-axner commented Mar 4, 2021

View reviewed changes

Merge branch 'master' into colin/remove-ibc

ab27bc3

colin-axner marked this pull request as ready for review March 4, 2021 12:32

colin-axner requested review from aaronc, alessio and alexanderbez as code owners March 4, 2021 12:32

colin-axner requested a review from amaury1093 March 4, 2021 12:33

alessio approved these changes Mar 4, 2021

View reviewed changes

alessio merged commit da064e1 into master Mar 4, 2021

alessio deleted the colin/remove-ibc branch March 4, 2021 13:11

webmaster128 mentioned this pull request Oct 20, 2021

Cosmos SDK 0.44 support cosmos/cosmjs#865

Closed

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023

Remove IBC from the SDK (cosmos#8735)

921e390

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove IBC from the SDK #8735

Remove IBC from the SDK #8735

colin-axner commented Mar 1, 2021 •

edited

Loading

colin-axner commented Mar 1, 2021

colin-axner Mar 1, 2021

AdityaSripal Mar 3, 2021

colin-axner Mar 1, 2021

amaury1093 Mar 1, 2021

colin-axner Mar 1, 2021

colin-axner Mar 3, 2021

colin-axner commented Mar 2, 2021

AdityaSripal left a comment

AdityaSripal Mar 3, 2021

colin-axner Mar 3, 2021

AdityaSripal Mar 3, 2021

colin-axner commented Mar 3, 2021

colin-axner Mar 4, 2021

codecov bot commented Mar 4, 2021

tac0turtle commented Mar 4, 2021

alessio commented Mar 5, 2021

colin-axner commented Mar 8, 2021

Remove IBC from the SDK #8735

Remove IBC from the SDK #8735

Conversation

colin-axner commented Mar 1, 2021 • edited Loading

Description

colin-axner commented Mar 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

colin-axner commented Mar 2, 2021

AdityaSripal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

colin-axner commented Mar 3, 2021

Choose a reason for hiding this comment

codecov bot commented Mar 4, 2021

Codecov Report

tac0turtle commented Mar 4, 2021

alessio commented Mar 5, 2021

colin-axner commented Mar 8, 2021

colin-axner commented Mar 1, 2021 •

edited

Loading