Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor x/staking according to ADR 031 #7556

Merged
merged 8 commits into from
Oct 16, 2020
Merged

Refactor x/staking according to ADR 031 #7556

merged 8 commits into from
Oct 16, 2020

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Oct 15, 2020 •
edited
Loading

Description

ref: #7500
closes: #7546

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 15, 2020 •
edited
Loading

Codecov Report

Merging #7556 into master will decrease coverage by 0.41%.
The diff coverage is 5.72%.

@@            Coverage Diff             @@
##           master    #7556      +/-   ##
==========================================
- Coverage   54.59%   54.18%   -0.42%     
==========================================
  Files         603      604       +1     
  Lines       38151    38159       +8     
==========================================
- Hits        20828    20675     -153     
- Misses      15204    15388     +184     
+ Partials     2119     2096      -23

@atheeshp atheeshp marked this pull request as ready for review October 15, 2020 12:36
blushi
blushi reviewed Oct 15, 2020
View reviewed changes
proto/cosmos/staking/v1beta1/tx.proto Outdated Show resolved Hide resolved
proto/cosmos/staking/v1beta1/tx.proto Outdated Show resolved Hide resolved
@atheeshp atheeshp mentioned this pull request Oct 16, 2020
Closed
16 tasks
blushi
blushi approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving

x/staking/handler_test.go Show resolved Hide resolved
x/staking/handler_test.go Show resolved Hide resolved
amaury1093
amaury1093 approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/staking/handler_test.go

finishTime, err := gogotypes.TimestampFromProto(ts)
var resData types.MsgUndelegateResponse
err = proto.Unmarshal(res.Data, &resData)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe app.AppCodec().UnmarshalBinaryBare is even more correct

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that won't work with amino though. I think it's okay

@aaronc aaronc added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 16, 2020
@mergify mergify bot merged commit 18ef33c into master Oct 16, 2020
@mergify mergify bot deleted the atheesh/7500-x-staking branch October 16, 2020 14:53
@clevinson clevinson mentioned this pull request Oct 19, 2020
Closed
16 tasks
clevinson pushed a commit that referenced this pull request Oct 19, 2020
@atheeshp @aaronc @clevinson
Refactor x/staking according to ADR 031 (#7556)
cfd51cf 
* Refactor x/staking according to ADR 031

* lint

* review changes

* review changes

* review changes

Co-authored-by: Aaron Craelius <[email protected]>
@clevinson clevinson mentioned this pull request Oct 19, 2020
Merged
9 tasks
aaronc added a commit that referenced this pull request Oct 20, 2020
@clevinson @aaronc
@amaury1093 @alexanderbez @blushi @mergify @atheeshp
[backport/v0.40.x] Implement ADR031 (#7599)
59a045f 
* Refactor RegisterQueryServices -> RegisterServices (#7518)

* Refactor RegisterQueryServices -> RegisterServices

* Fix tests

* Add ADR 031 BaseApp and codec infrastructure (#7519)

* Refactor RegisterQueryServices -> RegisterServices

* Cleaner proto files

* Fix tests

* Add MsgServer

* Fix lint

* Remove MsgServer from configurator for now

* Remove useless file

* Fix build

* typo

* Add router

* Fix test

* WIP

* Add router

* Remove test helper

* Add beginning of test

* Move test to simapp?

* ServiceMsg implement sdk.Msg

* Add handler by MsgServiceRouter

* Correct signature

* Add full test

* use TxEncoder

* Update baseapp/msg_service_router.go

Co-authored-by: Aaron Craelius <[email protected]>

* Push changes

* WIP on ServiceMsg unpacking

* Make TestMsgService test pass

* Fix tests

* Tidying up

* Tidying up

* Tidying up

* Add JSON test

* Add comments

* Tidying

* Lint

* Register MsgRequest interface

* Rename

* Fix tests

* RegisterCustomTypeURL

* Add changelog entries

* Put in features

* Update baseapp/msg_service_router.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update baseapp/msg_service_router.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update baseapp/msg_service_router.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update baseapp/msg_service_router.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update baseapp/msg_service_router.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update baseapp/msg_service_router.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update baseapp/msg_service_router.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Address review comments

* Address nit

* Fix lint

* Update codec/types/interface_registry.go

Co-authored-by: Marie Gauthier <[email protected]>

* godoc

Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Marie Gauthier <[email protected]>

* Refactor x/bank according to ADR 031 (#7520)

* Refactor x/bank according to ADR 031

* Add comment

* Update comment

* Add comment

* Add tests, address edge cases

* Imports

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Refactor x/{gov, crisis} according to ADR 031 (#7533)

* Refactor x/gov according to ADR 31

* fix tests

* Refactor x/crisis according to ADR 031

* fix lint

* lint

* lint

* review changes

* lint

* review change

* fic doc

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Refactor x/distribution according to ADR 031 (#7524)

* Refactor x/distribution according to ADR 31

* lint

* removed unused

* Apply suggestions from code review

Co-authored-by: Marie Gauthier <[email protected]>

Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: Marie Gauthier <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* [x/slashing] Implement Protobuf Msg Services (#7557)

* Update x/slashing to use proto msg service

* Fix proto-gen

Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Refactor x/auth/vesting to use ADR-031 (#7551)

* update auth/vesting module to use proto msg services

* rm accidental tmp files

* Update x/auth/vesting/msg_server.go

Co-authored-by: Marie Gauthier <[email protected]>

* golangci-lint fix

Co-authored-by: Marie Gauthier <[email protected]>
Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Refactor x/staking according to ADR 031 (#7556)

* Refactor x/staking according to ADR 031

* lint

* review changes

* review changes

* review changes

Co-authored-by: Aaron Craelius <[email protected]>

* Add MsgServer to Configurator for ADR 031 wiring (#7584)

* Add MsgServer to Configurator for ADR 031 wiring

* Add docs, wire up evidence & staking

* Add integration test

* Add comments

* Doc strings

* Update types/module/configurator.go

Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* Update types/module/configurator.go

Co-authored-by: Cory <[email protected]>

* Wire up vesting

* Update CHANGELOG.md

Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Amaury Martiny <[email protected]>
Co-authored-by: Cory <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Refactor x/evidence to ADR-031 (#7538)

* Refactor x/evidence to ADR-031

* Add hash in response

* Update changelog

* Update x/evidence/keeper/keeper.go

* Update proto/cosmos/evidence/v1beta1/tx.proto

Co-authored-by: Marie Gauthier <[email protected]>

* Use msgServer struct

Co-authored-by: Marie Gauthier <[email protected]>

* Refactor x/ibc to ADR 031 (#7576)

* WIP: Refactor x/ibc to ADR 031

* updated handler

* removed unsued

* fix

* Add proto service for ibc/transfer

* lint

* remove old upgrade handler

* added doc

* review changes

* fix tests

* formatter

* Add MsgServer wiring in RegisterServices

Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* add changelog entries for non-nil Result.Data fields in message responses

Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: Amaury Martiny <[email protected]>
Co-authored-by: Aaron Craelius <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Marie Gauthier <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: atheeshp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blushi blushi blushi approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@clevinson clevinson Awaiting requested review from clevinson

@anilcse anilcse Awaiting requested review from anilcse

@aleem1314 aleem1314 Awaiting requested review from aleem1314

@aaronc aaronc Awaiting requested review from aaronc

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[x/staking] Implement Protobuf Msg Services
5 participants
@atheeshp @aaronc @robert-zaremba @amaury1093 @blushi