staking tests #754
Merged
staking tests #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #754 +/- ##
===========================================
+ Coverage 59.52% 63.28% +3.75%
===========================================
Files 62 62
Lines 3274 3315 +41
===========================================
+ Hits 1949 2098 +149
+ Misses 1181 1069 -112
- Partials 144 148 +4 |
adrianbrink
reviewed
Mar 30, 2018
x/stake/handler.go
Outdated
| @@ -187,8 +176,12 @@ func BondCoins(ctx sdk.Context, k Keeper, bond DelegatorBond, candidate Candidat | |||
| if err != nil { | |||
| return err | |||
| } | |||
| newShares := k.candidateAddTokens(ctx, candidate, amount.Amount) | |||
| p := k.GetPool(ctx) | |||
| var newShares sdk.Rat | |||
There was a problem hiding this comment.
nit: := is probably cleaner here
There was a problem hiding this comment.
oh okay yeah can do that here actually. 👍
| // load/save the pool | ||
| func (k Keeper) GetPool(ctx sdk.Context) (gs Pool) { | ||
| // check if cached before anything | ||
| if k.gs != (Pool{}) { |
There was a problem hiding this comment.
Is a layer of caching on top of the multistore necessary?
There was a problem hiding this comment.
this is based off of conversation with jae/sunny in berlin... if retrieving multiple times why unmarshal multiple times
in progress in progress
in progress in progress done
rigelrozanski
force-pushed
the
rigel/tick-tests
branch
from
f1ebd67 to
7d67d00
Compare
rigelrozanski
changed the title
rigelrozanski
changed the title
|
closes: #571 |
cwgoes
approved these changes
Apr 3, 2018
|
cool thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tick tests / pool tests / keeper tests
closes #735
closes #731
closes #732
closes #571