Use enum instead of int32 for BondStatus #7499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sdk into am-migrate-followup
Co-authored-by: Marie Gauthier <[email protected]>
…sdk into am-migrate-followup
9 tasks
…igrate-followup-staking
Codecov Report
@@ Coverage Diff @@
## master #7499 +/- ##
==========================================
- Coverage 56.03% 56.01% -0.02%
==========================================
Files 592 592
Lines 37254 37244 -10
==========================================
- Hits 20874 20864 -10
Misses 14262 14262
Partials 2118 2118 |
amaury1093
requested review from
aaronc,
alessio and
alexanderbez
as code owners
amaury1093
requested review from
anilcse,
blushi,
robert-zaremba and
clevinson
anilcse
approved these changes
Oct 12, 2020
amaury1093
added
the
A:automerge
amaury1093
added a commit
that referenced
this pull request
Oct 12, 2020
* Migrate staking module * Add gov legacy * Add comments * Add x/distrib * x/crisis * x/mint * Fix test * migrate x/genutil * Fix lint * Fix staking constants * Fix test * Update x/genutil/legacy/v040/migrate.go Co-authored-by: Marie Gauthier <[email protected]> * Add migrate script instead of change BondStatus constants * Change staking bondStatus to enum * Fix test * Fix another test * Remove staking exported * fix references * Better constants * Fix build * Fix lint * Remove buf version * Fix tests * Fix test Co-authored-by: Marie Gauthier <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
clevinson
pushed a commit
that referenced
this pull request
Oct 19, 2020
* Use enum instead of int32 for BondStatus (#7499) * Migrate staking module * Add gov legacy * Add comments * Add x/distrib * x/crisis * x/mint * Fix test * migrate x/genutil * Fix lint * Fix staking constants * Fix test * Update x/genutil/legacy/v040/migrate.go Co-authored-by: Marie Gauthier <[email protected]> * Add migrate script instead of change BondStatus constants * Change staking bondStatus to enum * Fix test * Fix another test * Remove staking exported * fix references * Better constants * Fix build * Fix lint * Remove buf version * Fix tests * Fix test Co-authored-by: Marie Gauthier <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> * Update CHANGELOG Co-authored-by: Marie Gauthier <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Migrate staking module * Add gov legacy * Add comments * Add x/distrib * x/crisis * x/mint * Fix test * migrate x/genutil * Fix lint * Fix staking constants * Fix test * Update x/genutil/legacy/v040/migrate.go Co-authored-by: Marie Gauthier <[email protected]> * Add migrate script instead of change BondStatus constants * Change staking bondStatus to enum * Fix test * Fix another test * Remove staking exported * fix references * Better constants * Fix build * Fix lint * Remove buf version * Fix tests * Fix test Co-authored-by: Marie Gauthier <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BondStatus can take a small amount of variants, so an enum makes more sense.
Breaking changes:
BondedBOND_STATUS_BONDEDDepends on:
migratecommand follow-up: decode & re-encode #7464This PR is not a blocker for RC0, though it's a nice-to-have.
Note: BondStatus was in
types/stakingbefore. Now it's proto-generated, so it's inx/staking/types. This creates an import cycle:x/staking/exportedneedsx/staking/typesfor BondStatusx/staking/typesneedsx/staking/exportedfor interface implementation assertion.In this PR, I removed
x/staking/exportedand put the interfaces inx/staking/types. lmk if you can think of other ways to solve the import cycle.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes