Enable proto JSON for genesis #7000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7000 +/- ##
==========================================
+ Coverage 59.07% 61.91% +2.84%
==========================================
Files 363 520 +157
Lines 21499 32151 +10652
==========================================
+ Hits 12701 19907 +7206
- Misses 7755 10629 +2874
- Partials 1043 1615 +572 |
…ronc/enable-proto-genesis
aaronc
requested review from
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
aaronc
requested review from
atheeshp,
amaury1093,
anilcse,
blushi and
sahith-narahari
|
As long as types can be deserialized into the corresponding |
…ronc/enable-proto-genesis
sahith-narahari
approved these changes
Aug 11, 2020
amaury1093
approved these changes
Aug 11, 2020
| app = simapp.Setup(false) | ||
| appCodec, _ = simapp.MakeCodecs() | ||
| app = simapp.Setup(false) | ||
| appCodec, legacyAmino = simapp.MakeCodecs() |
There was a problem hiding this comment.
Probably a refactor for another PR, but MakeCodecs is redundant since we have MakeEncodingConfig, right?
There was a problem hiding this comment.
Yes more or less. It's a holdover from earlier versions
So it changes the JSON marshaler in the client context attached to the cobra command. Maybe worth studying that code a bit to understand how things work in the CLI |
…ronc/enable-proto-genesis
9 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Enable proto JSON for genesis * Test fixes * Cleanup * Cleanup * Cleanup * Update CHANGELOG.md * Protogen Co-authored-by: Federico Kunze <[email protected]> Co-authored-by: SaReN <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5917. (Was originally part of #6859 but split out into a smaller PR)
A few important notes:
GenesisDocnow usesencoding/jsonGenesisDocis now marshaled/unmarshaled using the golangencoding/jsoninstead of amino or proto JSON. Proto JSON will not work becauseGenesisDocis not aproto.Message(cc @marbar3778).As I understand it, this has the side effect that certain
int64/uint64types will be encoded as actual JSON integers as opposed to strings. If this is not okay we can either just use amino JSON or we will need proto support from tm.Note that this affects both proto and amino configurations of the SDK (although currently only proto works).
ProposalStatusnow uses default protobuf string formattingProposalStatusis now printed to JSON with its proto name, i.e.PROPOSAL_STATUS_DEPOSIT_PERIODvsDepositPeriodNewSimAppnow takes a parameter forEncodingConfigThis is necessary to export genesis with protobuf and in general may be useful for testing.
Pointer types must be used for
GenesisStateeverywhereThis is true for all
proto.Messagemarshaling.JSONMarshalershould just requireproto.Messageto avoid runtime errors, to be followed up in #6982 .Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes