Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter the new keyring interface #5904

Merged
merged 164 commits into from
Apr 8, 2020
Merged

Enter the new keyring interface #5904

merged 164 commits into from
Apr 8, 2020

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Apr 1, 2020

crypto/keyring:

Keybase interface gives way to its successor: Keyring. LegacyKeybase
interface is added in order to guarantee limited backward compatibility with
the old Keybase interface for the sole purpose of migrating keys across
the new keyring backends.

The package does no longer depends on the github.com/types.Config
singleton.

crypto/ subdirs reorganization: crypto/keys/hd was moved to crypto/hd,
which now groups together all HD Wallets related types and utilities.

SupportedAlgos and SupportedLedgerAlgos methods have been removed.
The keyring just fails when trying to perform an action with an unsupported
algorithm.

client/input:

  • Removal of unnecessary GetCheckPassword, PrintPrefixed functions.
  • GetConfirmation's signature changed to take in a io.Writer for better integration
    with cobra.Command types.

client/context:

  • In-memory keyring is allocated in the context when --gen-only flag is passed
    in. GetFromFields does no longer silently allocate a keyring, it takes one as
    argument.

Co-authored with @jgimeno


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio added C:Keys Keybase, KMS and HSMs R4R and removed WIP labels Apr 7, 2020
@alessio alessio marked this pull request as ready for review April 7, 2020 18:36
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

CHANGELOG.md Outdated Show resolved Hide resolved
@alessio alessio merged commit a1feca3 into master Apr 8, 2020
@alessio alessio deleted the alessio/new-keyring-interface branch April 8, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Crypto C:Keys Keybase, KMS and HSMs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants