-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enter the new keyring interface #5904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci]
alessio
requested review from
alexanderbez,
fedekunze,
hschoenburg and
nylira
as code owners
April 7, 2020 18:36
alexanderbez
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crypto/keyring:
Keybase
interface gives way to its successor:Keyring
.LegacyKeybase
interface is added in order to guarantee limited backward compatibility with
the old
Keybase
interface for the sole purpose of migrating keys acrossthe new keyring backends.
The package does no longer depends on the
github.com/types.Config
singleton.
crypto/ subdirs reorganization:
crypto/keys/hd
was moved tocrypto/hd
,which now groups together all HD Wallets related types and utilities.
SupportedAlgos
andSupportedLedgerAlgos
methods have been removed.The keyring just fails when trying to perform an action with an unsupported
algorithm.
client/input:
GetCheckPassword
,PrintPrefixed
functions.with cobra.Command types.
client/context:
--gen-only
flag is passedin.
GetFromFields
does no longer silently allocate a keyring, it takes one asargument.
Co-authored with @jgimeno
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)