-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proto Client Migration: x/bank #5865
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5865 +/- ##
==========================================
- Coverage 32.27% 31.79% -0.49%
==========================================
Files 355 358 +3
Lines 39447 40192 +745
==========================================
+ Hits 12731 12778 +47
- Misses 25440 26127 +687
- Partials 1276 1287 +11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-Authored-By: Aaron Craelius <[email protected]>
@@ -8,14 +8,72 @@ import ( | |||
"github.com/cosmos/cosmos-sdk/client" | |||
"github.com/cosmos/cosmos-sdk/client/context" | |||
"github.com/cosmos/cosmos-sdk/client/flags" | |||
"github.com/cosmos/cosmos-sdk/client/tx" | |||
clientx "github.com/cosmos/cosmos-sdk/client/tx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexanderbez this looks like a duplicate import, would you like me to remove this in slashing PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, please! good catch :)
client/tx
) for all signing and generating needs.PostProcessResponseBare
andPostProcessResponse
for Proto compatibilityref: #5864
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)