Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto Client Migration: x/bank #5865

Merged
merged 31 commits into from
Mar 26, 2020
Merged

Proto Client Migration: x/bank #5865

merged 31 commits into from
Mar 26, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 24, 2020

  • A few fixes and ADR updates to existing protobuf work.
  • Create new CLI handlers for x/bank that are proto compatible.
  • Create a framework (client/tx) for all signing and generating needs.
  • Prepare PostProcessResponseBare and PostProcessResponse for Proto compatibility

ref: #5864


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #5865 into master will decrease coverage by 0.48%.
The diff coverage is 11.6%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5865      +/-   ##
==========================================
- Coverage   32.27%   31.79%   -0.49%     
==========================================
  Files         355      358       +3     
  Lines       39447    40192     +745     
==========================================
+ Hits        12731    12778      +47     
- Misses      25440    26127     +687     
- Partials     1276     1287      +11
Impacted Files Coverage Δ
client/context/context.go 30.12% <0%> (-2.74%) ⬇️
x/distribution/handler.go 8.82% <0%> (ø) ⬆️
types/codec.go 27.27% <0%> (+2.27%) ⬆️
types/result.go 88.46% <0%> (-8.18%) ⬇️
x/auth/types/stdtx.go 53.16% <0%> (-1.03%) ⬇️
codec/std/tx.go 58.66% <0%> (-0.8%) ⬇️
types/types.pb.go 3.81% <0.63%> (-1.92%) ⬇️
x/crisis/handler.go 100% <100%> (ø) ⬆️
codec/proto_codec.go 63.33% <100%> (+0.83%) ⬆️
baseapp/baseapp.go 72.54% <100%> (ø) ⬆️
... and 13 more

@alexanderbez alexanderbez added R4R and removed WIP labels Mar 25, 2020
@alexanderbez alexanderbez marked this pull request as ready for review March 25, 2020 18:26
@alexanderbez alexanderbez requested a review from alessio as a code owner March 25, 2020 18:26
client/context/context.go Outdated Show resolved Hide resolved
client/tx/factory.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

client/tx/tx.go Outdated Show resolved Hide resolved
baseapp/abci.go Outdated Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Outdated Show resolved Hide resolved
@alexanderbez alexanderbez merged commit 6a9c8bc into master Mar 26, 2020
@alexanderbez alexanderbez deleted the bez/tx-client-proto-i branch March 26, 2020 18:25
@@ -8,14 +8,72 @@ import (
"github.com/cosmos/cosmos-sdk/client"
"github.com/cosmos/cosmos-sdk/client/context"
"github.com/cosmos/cosmos-sdk/client/flags"
"github.com/cosmos/cosmos-sdk/client/tx"
clientx "github.com/cosmos/cosmos-sdk/client/tx"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderbez this looks like a duplicate import, would you like me to remove this in slashing PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please! good catch :)

@clevinson clevinson added this to the v0.39 milestone May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants