-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert changes for keybase encoding. #5814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, can you confirm @alessio?
@alexanderbez I added a comment for the breaking client on the changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a request for an additional test case. Looks good otherwise
Codecov Report
@@ Coverage Diff @@
## master #5814 +/- ##
=======================================
Coverage 36.03% 36.03%
=======================================
Files 342 342
Lines 34782 34782
=======================================
Hits 12534 12534
Misses 20998 20998
Partials 1250 1250
|
Revert some changes done here:
#5799
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)