Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/distribution: simapp for testing #5725

Merged
merged 18 commits into from
Mar 5, 2020

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Feb 28, 2020

Closes: #4875

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jgimeno jgimeno added R4R C:x/distribution distribution module related T: Tests labels Mar 2, 2020
@jgimeno jgimeno marked this pull request as ready for review March 2, 2020 12:48
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #5725 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5725     +/-   ##
=========================================
+ Coverage   35.66%   35.96%   +0.3%     
=========================================
  Files         337      337             
  Lines       34639    34639             
=========================================
+ Hits        12354    12459    +105     
+ Misses      21056    20934    -122     
- Partials     1229     1246     +17
Impacted Files Coverage Δ
x/distribution/keeper/hooks.go 30.23% <100%> (ø) ⬆️
x/distribution/keeper/validator.go 87.23% <100%> (ø) ⬆️
x/distribution/keeper/delegation.go 68% <100%> (ø) ⬆️
x/distribution/keeper/querier.go 55.4% <100%> (ø) ⬆️
x/distribution/handler.go 8.82% <0%> (+1.47%) ⬆️
x/distribution/keeper/store.go 50% <0%> (+3.47%) ⬆️
x/distribution/genesis.go 10% <0%> (+10%) ⬆️
x/distribution/module.go 54.09% <0%> (+54.09%) ⬆️
x/distribution/keeper/invariants.go 54.63% <0%> (+54.63%) ⬆️

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 5, 2020
@tac0turtle tac0turtle changed the title Jonathan/4875 distribution keeper use simapp x/distribution: simapp for testing Mar 5, 2020
@mergify mergify bot merged commit 9acd722 into master Mar 5, 2020
@mergify mergify bot deleted the jonathan/4875-distribution-keeper-use-simapp branch March 5, 2020 14:00
@tac0turtle
Copy link
Member

ci tests should be marked as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/distribution distribution module related T: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate x/mock, transition integration tests to use simapp
4 participants