Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto: migrate x/evidence to hybridcodec #5634

Merged
merged 97 commits into from
Feb 24, 2020
Merged

proto: migrate x/evidence to hybridcodec #5634

merged 97 commits into from
Feb 24, 2020

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Feb 11, 2020 •
edited by alexanderbez
Loading

this pr includes mint module as it is smaller

Signed-off-by: Marko Baricevic [email protected]

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

alexanderbez and others added 30 commits January 7, 2020 15:53
@alexanderbez
Migrate types to use proto
adfae21
@alexanderbez
Add newline
72f70c0
@alexanderbez
Fix rand_util
80ab9d6
@alexanderbez
Add nolint
bf49ef2
@alexanderbez
Implement amino marshal interface for int, uint, and dec
d9c08cf
@alexanderbez
Update encoding doc
c5e5c6b
@alexanderbez
Update CircleCI config
c1b17a5
@alexanderbez
Remove tools target from proto job
28b2da6
@alexanderbez
Rename to CustomProtobufType
f039b99
@alexanderbez
Merge branch 'master' into bez/5444-types-proto-enc
49aa60d
@alexanderbez
Merge branch 'master' into bez/5444-types-proto-enc
cd092c0
changed proto docker image
b3463f7
changed proto job to skip the binary installs
f05929c
removed extra files and update proto CI
52e0a49
@alexanderbez
Use third_party over vendor
161f23b
@alexanderbez
Merge branch 'master' into bez/5444-types-proto-enc
5098419
@aaronc @alexanderbez
Merge PR #5505: Convert Int and Dec to string's on Coin and DecCoin p…
7501af3 
…roto types
@alexanderbez
Update go.sum
5c6c08c
@alexanderbez
Fix protoc-gen-gocosmos target by allowing versioning
2e80b77
@alexanderbez
Lint
9e6a906
@alexanderbez
Update go.{mod, sum} and install
33400ef
@alexanderbez
wildcard import
241eafb
@alexanderbez
Merge branch 'master' into bez/5444-types-proto-enc
489d5e0
@alexanderbez
go mod tidy
01f7766
@alexanderbez
Bump cosmos-proto to v0.1.0
bb4ae4e
@alexanderbez
Update go.{mod, sum}
d6182fb
@alexanderbez
Update third party proto deps
ba12a87
@alexanderbez
Define Marshaler and ProtoMarshaler interfaces along with BaseCodec type
153dadd
@alexanderbez
Initial commit/demo
94ca99c
@alexanderbez
Fix MarshalAccount
4113099
@alexanderbez alexanderbez marked this pull request as ready for review February 24, 2020 15:01
@alexanderbez alexanderbez added R4R and removed WIP labels Feb 24, 2020
alexanderbez
alexanderbez approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 🎉

@alexanderbez alexanderbez merged commit f7486b9 into master Feb 24, 2020
@alexanderbez alexanderbez deleted the proto/evidence branch February 24, 2020 16:05
@fedekunze
Copy link
Collaborator

why was the evidence msg removed?

@tac0turtle
Copy link
Member Author

tac0turtle commented Feb 26, 2020 •
edited
Loading

needs to be lifted to the app level so you will find the messge here: https://github.com/cosmos/cosmos-sdk/blob/master/simapp/codec/codec.proto

since it is a oneof that can be extended we need the app to define it, the samething will be done for accounts and gov proposal msgs

@alexanderbez
Copy link
Contributor

Read the ADR @fedekunze 😉

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@tac0turtle
Merge PR cosmos#5634: Protobuf - Migrate x/evidence
7c5486d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@anilcse anilcse anilcse left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees

@alexanderbez alexanderbez

Labels
C:x/evidence C:x/mint T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tac0turtle @fedekunze @alexanderbez @anilcse @golangcibot @aaronc