-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/ibc ICS24 #5588
x/ibc ICS24 #5588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except that I don't understand the "paths as sets" bit - paths aren't sets.
Do we use these identifier validation functions in (question from @jackzampolin) |
Sounds like we don't have a |
…-ics24-host-requirements
…s/cosmos-sdk into ib-ics24-host-requirements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK ☕️
Description
Adds subpackage
24-host/
to theibc
module, that incorporates the changes from the ICS 024 - Host State Machine Requirements spec.For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)