Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Query Txs by Events Command #5482

Merged
merged 7 commits into from
Jan 6, 2020
Merged

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 5, 2020

  • Remove old "tags" nomenclature
  • Use = instead of : to align and be consistent with the API variant
  • Cleanup events doc

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez added T:Docs Changes and features related to documentation. C:CLI WIP labels Jan 5, 2020
@alexanderbez alexanderbez marked this pull request as ready for review January 5, 2020 20:16
@alexanderbez alexanderbez added R4R and removed WIP labels Jan 5, 2020
x/auth/client/cli/query.go Outdated Show resolved Hide resolved
x/auth/client/cli/query.go Outdated Show resolved Hide resolved
alexanderbez and others added 2 commits January 6, 2020 11:39
@alexanderbez alexanderbez merged commit 25be589 into master Jan 6, 2020
@alexanderbez alexanderbez deleted the bez/fix-txs-events-query-cmd branch January 6, 2020 16:49
@alexanderbez alexanderbez mentioned this pull request Jan 7, 2020
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants