Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Store Accessor Types #4514
R4R: Store Accessor Types #4514
Changes from 8 commits
9375649
16eea68
f73215e
cf0b8f2
e25f652
2b17a39
dc84e1e
19d7155
6764bc4
8affaa7
a7898b4
3939bd4
f609249
7da69c1
600445a
94e2cdc
8d9e779
92d0fb4
5d913b7
699b0ba
97edd89
24e621a
971a642
fcad487
6de0ed5
6dc912f
63c6f3c
b6441c0
4d723ae
244d2c2
7bf4d57
7471bdf
04543f8
10d1c46
09e6600
6f5f633
4116bb7
8040c81
828badd
21bd8d0
9b3b120
abd9fec
a6dadef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the name either
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transit
is used for moving the stored state fromfrom
toto
. Mostly used for the handshaking process in connection and channel. NamedEnum
because it is essentially abyte
and considered as an enum type. Can be changed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ix.m undefined (type Indexer has no field or method m) (from
typecheck
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ix.enc undefined (type Indexer has no field or method enc) (from
typecheck
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems cleaner if we instead internally call
GetSafe
but panic on error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get
should panic on unmarshal error, but not on nil value error, so usingGetSafe
internally will cause type switching on errorsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we panic'ing here? We should rather return an error, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: these are the basic fields used on a
Keeper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment really has no context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
U1000: func
Mapping.store
is unused (fromunused
)