-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tx send (generate-only) to actually work offline #4234
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4234 +/- ##
==========================================
- Coverage 60.15% 60.13% -0.02%
==========================================
Files 212 212
Lines 15223 15223
==========================================
- Hits 9157 9155 -2
- Misses 5431 5433 +2
Partials 635 635 |
@@ -29,10 +29,6 @@ func SendTxCmd(cdc *codec.Codec) *cobra.Command { | |||
WithCodec(cdc). | |||
WithAccountDecoder(cdc) | |||
|
|||
if err := cliCtx.EnsureAccountExists(); err != nil { | |||
return err | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should disable this test only when generate mode is on (and leave it otherwise)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, but no need to. No other command work like this. When you omit --generate-only
, EnsureAccountExists
does get called. So having it here was wrong and superfluous.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added a relevant changelog entry:
clog add [section] [stanza] [message]
rereviewed
Files changed
in the github PR explorerFor Admin Use: