-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: gaiakeyutil -> gaiacli keys parse #4228
Conversation
Incorporate gaiakeyutil functionalities into gaiacli.
Codecov Report
@@ Coverage Diff @@
## master #4228 +/- ##
==========================================
+ Coverage 60.16% 60.24% +0.07%
==========================================
Files 212 213 +1
Lines 15188 15250 +62
==========================================
+ Hits 9138 9187 +49
- Misses 5421 5432 +11
- Partials 629 631 +2 |
Co-Authored-By: alessio <[email protected]>
Co-Authored-By: alessio <[email protected]>
Co-Authored-By: alessio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although do we want to add a test case for the CLI and update the docs too ?
@fedekunze this small utility hadn't made it into docs back then - I'm planning to incorporate |
Co-Authored-By: alessio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestedACK.
…-sdk into alessio/remove-gaiakeyutil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testedACK.
Incorporate
gaiakeyutil
functionalities into gaiacli.We would neither build nor install
gaiakeyutil
anymore, key string simple parsing functionality would be merged intogaiacli keys parse
.This is a call for a preliminary review, pending entry will eventually be added.
docs/
)sdkch add [section] [stanza] [message]
Files changed
in the github PR explorerFor Admin Use: