Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn --from into a positional argument in gaiacli tx send #4146

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Turn --from into a positional argument in gaiacli tx send #4146

merged 1 commit into from
Apr 18, 2019
+24 −23

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Apr 17, 2019 •
edited by alexanderbez
Loading

Closes: #4142

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 17, 2019 •
edited
Loading

Codecov Report

Merging #4146 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4146      +/-   ##
===========================================
- Coverage     60.2%   60.18%   -0.03%     
===========================================
  Files          212      212              
  Lines        15157    15157              
===========================================
- Hits          9126     9122       -4     
- Misses        5407     5411       +4     
  Partials       624      624

@alessio alessio requested review from fedekunze and sabau April 17, 2019 16:12
fedekunze
fedekunze approved these changes Apr 17, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alexanderbez
alexanderbez suggested changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit.

.pending/breaking/gaiacli/4142-Turn-gaiacli-tx Outdated Show resolved Hide resolved
docs/cosmos-hub/gaiacli.md Outdated Show resolved Hide resolved
@alessio
Copy link
Contributor Author

alessio commented Apr 17, 2019

ACKing suggestions, will amend shortly.

sabau
sabau approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have Bez comment addressed, I'll see it also as a client of those docs to fix some AWS nodes.

client/context/context.go Show resolved Hide resolved
@alessio alessio requested a review from alexanderbez April 18, 2019 16:17
@alessio alessio force-pushed the alessio/from-flag-to-argument branch from 237d6ba to c46ad04 Compare April 18, 2019 16:19
@alessio
Copy link
Contributor Author

alessio commented Apr 18, 2019

Comments have been addressed

@alessio alessio force-pushed the alessio/from-flag-to-argument branch from 4e77289 to a0ed0d4 Compare April 18, 2019 18:22
@alessio alessio merged commit 93e8f46 into develop Apr 18, 2019
@alessio alessio deleted the alessio/from-flag-to-argument branch April 18, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@fedekunze fedekunze fedekunze approved these changes

@sabau sabau sabau approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn --from into a positional argument in gaiacli tx send
4 participants
@alessio @sabau @alexanderbez @fedekunze