Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs from release/v0.34.0 #4089

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Update docs from release/v0.34.0 #4089

merged 1 commit into from
Apr 10, 2019

Conversation

alexanderbez
Copy link
Contributor

This will fix and resolve the conflicts from release/v0.34.0 into develop as the former has the canonical docs.


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #4089 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4089      +/-   ##
===========================================
+ Coverage    59.94%   59.98%   +0.03%     
===========================================
  Files          211      211              
  Lines        15111    15111              
===========================================
+ Hits          9058     9064       +6     
+ Misses        5433     5427       -6     
  Partials       620      620

@alexanderbez alexanderbez merged commit eb94252 into develop Apr 10, 2019
@alexanderbez alexanderbez deleted the bez/fix-gaia-docs branch April 10, 2019 15:55
alessio pushed a commit that referenced this pull request Apr 16, 2019
Fix empty path in `Install Go`.

This bug was fixed by #3975, and broken by #4089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants