Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: client/utils/ reorganization #3487

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Feb 2, 2019

Move REST-related types and functions out of client/utils into a new client/rest package.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Feb 2, 2019

Codecov Report

Merging #3487 into develop will decrease coverage by 6.42%.
The diff coverage is 80%.

@@             Coverage Diff             @@
##           develop    #3487      +/-   ##
===========================================
- Coverage    59.44%   53.02%   -6.43%     
===========================================
  Files          130      137       +7     
  Lines         9804    10733     +929     
===========================================
- Hits          5828     5691     -137     
- Misses        3606     4692    +1086     
+ Partials       370      350      -20

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - sure, this seems a bit cleaner

Move REST-related types and functions out of client/utils
into a new client/rest package.
@alessio alessio force-pushed the alessio/client-utils-reorg branch from 57d464e to ee9ea20 Compare February 4, 2019 05:09
@jleni
Copy link
Member

jleni commented Feb 4, 2019

If this is ready to go, please merge and I will rebase my PR that has some conflicting/similar changes.

@jackzampolin jackzampolin merged commit c04c696 into develop Feb 4, 2019
@jackzampolin jackzampolin deleted the alessio/client-utils-reorg branch February 4, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants