Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Make tags and responses legible #3451

Merged
merged 12 commits into from
Feb 5, 2019
Merged

R4R: Make tags and responses legible #3451

merged 12 commits into from
Feb 5, 2019

Conversation

jackzampolin
Copy link
Member

Replaces: #3277

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jackzampolin jackzampolin mentioned this pull request Jan 30, 2019
Closed
5 tasks
@jackzampolin jackzampolin changed the title WIP: Make tags and responses legible R4R: Make tags and responses legible Jan 30, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #3451 into develop will not change coverage.
The diff coverage is 86.88%.

@@           Coverage Diff            @@
##           develop    #3451   +/-   ##
========================================
  Coverage    52.69%   52.69%           
========================================
  Files          142      142           
  Lines        10364    10364           
========================================
  Hits          5461     5461           
  Misses        4574     4574           
  Partials       329      329

@jackzampolin jackzampolin changed the title R4R: Make tags and responses legible WIP: Make tags and responses legible Jan 31, 2019
@jackzampolin
Copy link
Member Author

Ok, so I have the gaiacli tx commands printing properly, but the tags for the gaiacli q tx(s) commands are returning base64 encoded strings for tags. Working on a fix

alessio
alessio reviewed Jan 31, 2019
View reviewed changes
client/context/context.go Outdated Show resolved Hide resolved
alexanderbez
alexanderbez suggested changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackzampolin this is great and I love the approach taken here. I think we can cleanup some of the logic even further (see my comment).

client/context/broadcast.go Outdated Show resolved Hide resolved
alexanderbez
alexanderbez reviewed Jan 31, 2019
View reviewed changes
types/result.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez mentioned this pull request Jan 31, 2019
Closed
@jackzampolin jackzampolin mentioned this pull request Feb 2, 2019
Merged
5 tasks
alessio
alessio reviewed Feb 3, 2019
View reviewed changes
types/tags.go Show resolved Hide resolved
@jackzampolin jackzampolin changed the title WIP: Make tags and responses legible R4R: Make tags and responses legible Feb 4, 2019
alexanderbez
alexanderbez suggested changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jackzampolin -- tested locally. I left a few comments.

client/tx/query.go Outdated Show resolved Hide resolved
types/result.go Outdated Show resolved Hide resolved
types/result.go Outdated Show resolved Hide resolved
alexanderbez
alexanderbez approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestedACK (on a tx send)

@alexanderbez
Copy link
Contributor

@jackzampolin this needs a pending log entry and merge conflict resolution.

alessio
alessio previously requested changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change - looks good otherwise

client/context/context.go Outdated Show resolved Hide resolved
@jackzampolin
Copy link
Member Author

Will merge when tests pass cc @alessio

@jackzampolin jackzampolin dismissed alessio’s stale review February 5, 2019 02:20

Approved in person by @alessio

@jackzampolin jackzampolin merged commit 5e35354 into develop Feb 5, 2019
@jackzampolin jackzampolin deleted the jack/legible-tags branch February 5, 2019 02:21
@jackzampolin jackzampolin mentioned this pull request Feb 8, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio alessio left review comments

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackzampolin @alexanderbez @alessio