Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: tombstone spec v2 #3416

Closed
wants to merge 1 commit into from
Closed

WIP: tombstone spec v2 #3416

wants to merge 1 commit into from

Conversation

sunnya97
Copy link
Member

@sunnya97 sunnya97 commented Jan 28, 2019

Moved from: #3103

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@sunnya97 sunnya97 requested a review from zramsay as a code owner January 28, 2019 19:07
@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #3416 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3416      +/-   ##
===========================================
- Coverage    59.35%   59.33%   -0.03%     
===========================================
  Files          131      131              
  Lines         9868     9868              
===========================================
- Hits          5857     5855       -2     
- Misses        3639     3641       +2     
  Partials       372      372

@sunnya97 sunnya97 closed this Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant