Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: fix regression in gaiacli config file handling #3316

Merged
merged 5 commits into from
Jan 17, 2019
Merged

R4R: fix regression in gaiacli config file handling #3316

merged 5 commits into from
Jan 17, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jan 17, 2019

--chain-id must be a persistent flag to be successfully read from config.

Closes: #810

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio changed the title fix regression in gaiacli config file handling R4R: fix regression in gaiacli config file handling Jan 17, 2019
@codecov
Copy link

codecov bot commented Jan 17, 2019 •
edited
Loading

Codecov Report

Merging #3316 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3316   +/-   ##
========================================
  Coverage    55.62%   55.62%           
========================================
  Files          132      132           
  Lines         9540     9540           
========================================
  Hits          5307     5307           
  Misses        3898     3898           
  Partials       335      335

cwgoes
cwgoes suggested changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine; tested OK. Can we document the gaiacli configuration file location & include an example in the docs somewhere?

alexanderbez
alexanderbez approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval pending docs suggestion by @cwgoes

@alessio alessio requested a review from zramsay as a code owner January 17, 2019 15:17
@cwgoes cwgoes merged commit 20bcacf into develop Jan 17, 2019
@cwgoes cwgoes deleted the alessio/810-config-handling-regression branch January 17, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@zramsay zramsay Awaiting requested review from zramsay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @alexanderbez @cwgoes