WIP: Increase decimal precision to 18 #3272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, is there a reason we can't use an existing library, such as https://godoc.org/golang.org/x/image/math/fixed or https://github.com/shopspring/decimal? |
cwgoes
force-pushed
the
cwgoes/mclaren-mcl33-first-pass
branch
from
63a589f to
c9a4978
Compare
|
yes - we want to maintain our own decimal library for the time being taking over this issue now! |
rigelrozanski
changed the base branch from
cwgoes/mclaren-mcl33-first-pass
to
develop
rigelrozanski
changed the base branch from
develop
to
cwgoes/mclaren-mcl33-first-pass
|
closing in favour of #3315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3039
cc @rigelrozanski
Nonfunctional at the moment; we must have some subtle dependency on 10 decimal points.
For Admin Use: