Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Support adding offline pubkeys to gaiacli keys #3224

Merged
merged 4 commits into from
Jan 8, 2019
Merged

R4R: Support adding offline pubkeys to gaiacli keys #3224

merged 4 commits into from
Jan 8, 2019

Conversation

jackzampolin
Copy link
Member

Replaces #3202

  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@jackzampolin jackzampolin mentioned this pull request Jan 4, 2019
Closed
5 tasks
@jackzampolin
Copy link
Member Author

cc @alexanderbez @zmanian @alessio

@codecov
Copy link

codecov bot commented Jan 4, 2019 •
edited
Loading

Codecov Report

Merging #3224 into develop will decrease coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #3224      +/-   ##
===========================================
- Coverage    55.37%   55.33%   -0.05%     
===========================================
  Files          134      134              
  Lines         9594     9601       +7     
===========================================
  Hits          5313     5313              
- Misses        3949     3956       +7     
  Partials       332      332

alexanderbez
alexanderbez approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- one minor remark.

client/keys/add.go Outdated Show resolved Hide resolved
@alexanderbez @jackzampolin
Update client/keys/add.go
9994ff7 
Co-Authored-By: jackzampolin <[email protected]>
cwgoes
cwgoes approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a line to the docs describing how to do this (next to the multisig section, perhaps)?

Otherwise LGTM.

alessio
alessio approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovin' this 👍

@jackzampolin jackzampolin merged commit 0e26a39 into develop Jan 8, 2019
@jackzampolin jackzampolin deleted the jack/add-offline-pubkeys branch January 8, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio alessio approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@zmanian zmanian Awaiting requested review from zmanian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackzampolin @alessio @alexanderbez @cwgoes