[R4R]: Cleanup bank keeper #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
wip
Type: Code Hygiene
alexanderbez
requested review from
jaekwon,
alessio,
sunnya97,
ValarDragon,
rigelrozanski and
cwgoes
Codecov Report
@@ Coverage Diff @@
## release/v0.26.0 #2719 +/- ##
===================================================
- Coverage 57.63% 57.62% -0.02%
===================================================
Files 154 154
Lines 9570 9563 -7
===================================================
- Hits 5516 5511 -5
+ Misses 3690 3688 -2
Partials 364 364 |
alessio
approved these changes
Nov 7, 2018
|
@cwgoes mind getting this in (I'd like another approval)? |
|
@alexanderbez Here is the context for why the Keepers are like this. #831 (comment) |
|
@rigelrozanski addressed your comments 👍 |
rigelrozanski
approved these changes
Nov 8, 2018
cwgoes
approved these changes
Nov 8, 2018
|
@sunnya97 I don't think we have diamond inheritance in this case, so this pattern seems OK. |
|
Yea there is no diamond inheritance here afaict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bank keeper was broken up into sub-interfaces (view, send, main). However, we were repeating a bulk of the methods in each. This simply removes duplicate code and DRYs it up.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: