Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organize the docs/ directory #2695

Merged
merged 13 commits into from
Nov 6, 2018
Merged

organize the docs/ directory #2695

merged 13 commits into from
Nov 6, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Nov 5, 2018

see the commit messages for a precise overview of the changes

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@@ -203,3 +203,38 @@ and all the semantics of the Ethereum state machine.

Within `x/eth`, transactions sent to particular addresses can be handled in unique ways,
for instance to handle IBC and staking.

# cosmos-sdk-cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tooling is WIP and not ready for usage. Its currently way out of sync with the codebase and needs updating. I think we should leave out mentions to it if we can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, zach is only working on reorg, and I will work on content on another PR (fixing links, removing/updating depracted stuff, etc.

@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #2695 into docs-overhaul will increase coverage by 0.9%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           docs-overhaul    #2695     +/-   ##
================================================
+ Coverage          58.01%   58.92%   +0.9%     
================================================
  Files                153      152      -1     
  Lines               9511     8840    -671     
================================================
- Hits                5518     5209    -309     
+ Misses              3632     3283    -349     
+ Partials             361      348     -13

@zramsay zramsay merged commit 91a9a1d into docs-overhaul Nov 6, 2018
@zramsay zramsay deleted the zach/moving-day branch November 6, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants